Files
Evection/apps/articles/test_rule_dispatch.py
T
ksmithandClaude Sonnet 5 753ae9efc7 Make Starred and Saved-for-later pre-configured system tags
UserArticleState.is_starred/is_saved_for_later/starred_at are gone —
starring and saving now add/remove an ArticleTag against a per-user
"Starred" / "Saved for later" Tag, created lazily on first use and marked
Tag.is_system=True. is_read/is_hidden stay on UserArticleState since
they're genuine reading state, not categorization, which is what made
these two candidates for unifying into the general tag mechanism.

System tags are excluded from the Manage Tags page and from delete_tag
(get_object_or_404 now requires is_system=False, so attempting to delete
one 404s) and from the subscription-tag autocomplete, since they
categorize articles, not feeds. The star/save icons are still exactly
where they were — this only changes what powers them.

apps.rules.engine's star action now does get_system_tag + ArticleTag.
get_or_create instead of setting a boolean field. A data migration
converts every existing is_starred=True/is_saved_for_later=True row into
its ArticleTag equivalent before the fields are dropped — verified by
seeding the pre-removal schema directly (including a row with both flags
set) and confirming the migration produces the right tags.

apps.articles.queries.with_user_state gained one more query (tag lookup
for the current page's articles) to stay in the same "fixed number of
queries regardless of article count" shape it already had.

Verified end to end against a running dev server: toggling star/saved,
the starred/saved filters, the sidebar's Favourites count, and that the
Starred tag doesn't appear on the Manage Tags page.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-10-30 21:36:44 -06:00

153 lines
5.3 KiB
Python

import pytest
from django.contrib.auth import get_user_model
from apps.feeds.models import Feed, Subscription
from apps.rules.models import FilterRule
from .models import STARRED_TAG_NAME, Article, ArticleTag, SubscriptionTag, Tag, UserArticleState
from .tasks import apply_filter_rules_for_feed
User = get_user_model()
def is_starred(user, article):
return ArticleTag.objects.filter(
user=user, article=article, tag__is_system=True, tag__name=STARRED_TAG_NAME
).exists()
@pytest.fixture
def feed(db):
return Feed.objects.create(feed_url="https://example.com/feed.xml", title="Example Feed")
@pytest.fixture
def alice(db):
return User.objects.create_user("alice", password="pw-alice-123")
@pytest.fixture
def bob(db):
return User.objects.create_user("bob", password="pw-bob-123")
@pytest.mark.django_db
def test_dispatch_applies_rules_only_for_subscribers_with_matching_rules(feed, alice, bob):
Subscription.objects.create(user=alice, feed=feed)
Subscription.objects.create(user=bob, feed=feed)
FilterRule.objects.create(
user=alice,
match_field=FilterRule.FIELD_TITLE,
match_type=FilterRule.MATCH_CONTAINS,
match_value="Python",
action=FilterRule.ACTION_STAR,
)
article = Article.objects.create(feed=feed, guid="guid-1", title="Python 4 released")
apply_filter_rules_for_feed(feed.id, [article.pk])
assert is_starred(alice, article) is True
# Bob has no rules, so he should get no state row at all.
assert not UserArticleState.objects.filter(user=bob, article=article).exists()
@pytest.mark.django_db
def test_feed_scoped_rule_does_not_apply_to_other_feeds(alice):
feed_a = Feed.objects.create(feed_url="https://a.example.com/feed.xml")
feed_b = Feed.objects.create(feed_url="https://b.example.com/feed.xml")
Subscription.objects.create(user=alice, feed=feed_a)
Subscription.objects.create(user=alice, feed=feed_b)
FilterRule.objects.create(
user=alice,
feed=feed_a,
match_field=FilterRule.FIELD_TITLE,
match_type=FilterRule.MATCH_CONTAINS,
match_value="Python",
action=FilterRule.ACTION_STAR,
)
article_a = Article.objects.create(feed=feed_a, guid="guid-1", title="Python news")
article_b = Article.objects.create(feed=feed_b, guid="guid-2", title="Python news too")
apply_filter_rules_for_feed(feed_a.id, [article_a.pk])
apply_filter_rules_for_feed(feed_b.id, [article_b.pk])
assert is_starred(alice, article_a) is True
assert not UserArticleState.objects.filter(user=alice, article=article_b).exists()
@pytest.mark.django_db
def test_tag_scoped_rule_only_applies_to_feeds_carrying_that_tag(alice, feed):
other_feed = Feed.objects.create(feed_url="https://other.example.com/feed.xml")
tagged_sub = Subscription.objects.create(user=alice, feed=feed)
Subscription.objects.create(user=alice, feed=other_feed)
tag = Tag.objects.create(user=alice, name="Tech")
SubscriptionTag.objects.create(user=alice, subscription=tagged_sub, tag=tag)
FilterRule.objects.create(
user=alice,
tag=tag,
match_field=FilterRule.FIELD_TITLE,
match_type=FilterRule.MATCH_CONTAINS,
match_value="Python",
action=FilterRule.ACTION_STAR,
)
tagged_article = Article.objects.create(feed=feed, guid="guid-1", title="Python in tagged feed")
untagged_article = Article.objects.create(
feed=other_feed, guid="guid-2", title="Python in untagged feed"
)
apply_filter_rules_for_feed(feed.id, [tagged_article.pk])
apply_filter_rules_for_feed(other_feed.id, [untagged_article.pk])
assert is_starred(alice, tagged_article) is True
assert not UserArticleState.objects.filter(user=alice, article=untagged_article).exists()
@pytest.mark.django_db
def test_rule_scoped_to_one_tag_still_applies_to_a_feed_with_multiple_tags(alice, feed):
subscription = Subscription.objects.create(user=alice, feed=feed)
tech_tag = Tag.objects.create(user=alice, name="Tech")
news_tag = Tag.objects.create(user=alice, name="News")
SubscriptionTag.objects.create(user=alice, subscription=subscription, tag=tech_tag)
SubscriptionTag.objects.create(user=alice, subscription=subscription, tag=news_tag)
FilterRule.objects.create(
user=alice,
tag=news_tag,
match_field=FilterRule.FIELD_TITLE,
match_type=FilterRule.MATCH_CONTAINS,
match_value="Python",
action=FilterRule.ACTION_STAR,
)
article = Article.objects.create(feed=feed, guid="guid-1", title="Python news")
apply_filter_rules_for_feed(feed.id, [article.pk])
assert is_starred(alice, article) is True
@pytest.mark.django_db
def test_disabled_rule_does_not_apply(feed, alice):
Subscription.objects.create(user=alice, feed=feed)
FilterRule.objects.create(
user=alice,
match_field=FilterRule.FIELD_TITLE,
match_type=FilterRule.MATCH_CONTAINS,
match_value="Python",
action=FilterRule.ACTION_STAR,
is_enabled=False,
)
article = Article.objects.create(feed=feed, guid="guid-1", title="Python 4 released")
apply_filter_rules_for_feed(feed.id, [article.pk])
assert not UserArticleState.objects.filter(user=alice, article=article).exists()
@pytest.mark.django_db
def test_dispatch_with_empty_article_ids_is_a_noop(feed):
assert apply_filter_rules_for_feed(feed.id, []) == 0