Files
Evection/apps/feeds/test_subscription_views.py
T
ksmithandClaude Sonnet 5 f818b11041 Accept a FreshRSS "Export" .zip directly for OPML import
FreshRSS's Export feature produces a .zip (an .opml.xml plus a starred-
articles .json this app doesn't import) rather than a bare .opml file —
uploading that zip as-is failed with "That file doesn't look like a valid
OPML export" since defusedxml can't parse a zip as XML.

apps.feeds.opml.extract_opml_bytes detects a zip upload and pulls the
.opml/.opml.xml member out of it before parsing; a bare .opml upload is
returned unchanged, so existing behavior is untouched. Verified against
the reporter's actual FreshRSS export (18 feeds across 6 categories) both
directly through extract_opml_bytes/parse_opml and as a real upload
through the running app.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-10-30 21:45:16 -06:00

213 lines
7.3 KiB
Python

import pytest
from django.contrib.auth import get_user_model
from django.core.files.uploadedfile import SimpleUploadedFile
from django.urls import reverse
from .models import Feed, Subscription
from .test_opml import SIMPLE_OPML
User = get_user_model()
@pytest.fixture
def alice(db):
return User.objects.create_user("alice", password="pw-alice-123")
@pytest.fixture
def bob(db):
return User.objects.create_user("bob", password="pw-bob-123")
@pytest.fixture
def alices_subscription(alice):
feed = Feed.objects.create(feed_url="https://example.com/feed.xml", title="Example")
return Subscription.objects.create(user=alice, feed=feed)
@pytest.mark.django_db
def test_subscription_list_requires_login(client):
response = client.get(reverse("feeds:subscription_list"))
assert response.status_code == 302
@pytest.mark.django_db
def test_subscription_list_shows_only_own_subscriptions(client, alice, bob, alices_subscription):
client.login(username="bob", password="pw-bob-123")
response = client.get(reverse("feeds:subscription_list"))
assert "Example" not in response.content.decode()
@pytest.mark.django_db
def test_edit_subscription_updates_title(client, alice, alices_subscription):
client.login(username="alice", password="pw-alice-123")
response = client.post(
reverse("feeds:edit_subscription", args=[alices_subscription.pk]),
{"custom_title": "My Example Feed"},
)
assert response.status_code == 302
alices_subscription.refresh_from_db()
assert alices_subscription.custom_title == "My Example Feed"
@pytest.mark.django_db
def test_user_cannot_edit_another_users_subscription(client, alice, bob, alices_subscription):
client.login(username="bob", password="pw-bob-123")
response = client.get(reverse("feeds:edit_subscription", args=[alices_subscription.pk]))
assert response.status_code == 404
@pytest.mark.django_db
def test_add_tag_to_subscription_creates_tag_and_link(client, alice, alices_subscription):
from apps.articles.models import SubscriptionTag, Tag
client.login(username="alice", password="pw-alice-123")
response = client.post(
reverse("feeds:add_tag_to_subscription", args=[alices_subscription.pk]),
{"tag_name": "backend"},
)
assert response.status_code == 200
tag = Tag.objects.get(user=alice, name="backend")
assert SubscriptionTag.objects.filter(
user=alice, subscription=alices_subscription, tag=tag
).exists()
assert b"backend" in response.content
@pytest.mark.django_db
def test_remove_tag_from_subscription(client, alice, alices_subscription):
from apps.articles.models import SubscriptionTag, Tag
client.login(username="alice", password="pw-alice-123")
tag = Tag.objects.create(user=alice, name="backend")
SubscriptionTag.objects.create(user=alice, subscription=alices_subscription, tag=tag)
response = client.post(
reverse("feeds:remove_tag_from_subscription", args=[alices_subscription.pk, tag.pk])
)
assert response.status_code == 200
assert not SubscriptionTag.objects.filter(
user=alice, subscription=alices_subscription, tag=tag
).exists()
@pytest.mark.django_db
def test_user_cannot_tag_another_users_subscription(client, alice, bob, alices_subscription):
client.login(username="bob", password="pw-bob-123")
response = client.post(
reverse("feeds:add_tag_to_subscription", args=[alices_subscription.pk]),
{"tag_name": "backend"},
)
assert response.status_code == 404
@pytest.mark.django_db
def test_unsubscribe(client, alice, alices_subscription):
client.login(username="alice", password="pw-alice-123")
response = client.post(reverse("feeds:unsubscribe", args=[alices_subscription.pk]))
assert response.status_code == 302
assert not Subscription.objects.filter(pk=alices_subscription.pk).exists()
@pytest.mark.django_db
def test_user_cannot_unsubscribe_another_users_subscription(
client, alice, bob, alices_subscription
):
client.login(username="bob", password="pw-bob-123")
response = client.post(reverse("feeds:unsubscribe", args=[alices_subscription.pk]))
assert response.status_code == 404
assert Subscription.objects.filter(pk=alices_subscription.pk).exists()
@pytest.mark.django_db
def test_import_opml_view_creates_subscriptions(client, alice):
client.login(username="alice", password="pw-alice-123")
upload = SimpleUploadedFile("subs.opml", SIMPLE_OPML, content_type="text/x-opml")
response = client.post(reverse("feeds:import_opml"), {"opml_file": upload})
assert response.status_code == 302
assert Subscription.objects.filter(user=alice).count() == 2
@pytest.mark.django_db
def test_import_opml_view_accepts_a_freshrss_export_zip(client, alice):
import zipfile
from io import BytesIO
client.login(username="alice", password="pw-alice-123")
buf = BytesIO()
with zipfile.ZipFile(buf, "w") as archive:
archive.writestr("feeds_2026-10-30.opml.xml", SIMPLE_OPML)
archive.writestr("starred_2026-10-30.json", b'{"items": []}')
upload = SimpleUploadedFile(
"freshrss_export.zip", buf.getvalue(), content_type="application/zip"
)
response = client.post(reverse("feeds:import_opml"), {"opml_file": upload})
assert response.status_code == 302
assert Subscription.objects.filter(user=alice).count() == 2
@pytest.mark.django_db
def test_import_opml_view_rejects_malformed_file(client, alice):
client.login(username="alice", password="pw-alice-123")
upload = SimpleUploadedFile("subs.opml", b"not xml at all", content_type="text/x-opml")
response = client.post(reverse("feeds:import_opml"), {"opml_file": upload})
assert response.status_code == 302
assert not Subscription.objects.filter(user=alice).exists()
@pytest.mark.django_db
def test_import_opml_dispatches_background_task_above_threshold(client, alice, monkeypatch):
client.login(username="alice", password="pw-alice-123")
dispatched = {}
def fake_delay(user_id, content):
dispatched["user_id"] = user_id
dispatched["content"] = content
from . import views as feeds_views
monkeypatch.setattr(feeds_views.import_opml_task, "delay", fake_delay)
monkeypatch.setattr(feeds_views, "OPML_ASYNC_THRESHOLD", 1)
upload = SimpleUploadedFile("subs.opml", SIMPLE_OPML, content_type="text/x-opml")
response = client.post(reverse("feeds:import_opml"), {"opml_file": upload})
assert response.status_code == 302
assert dispatched["user_id"] == alice.id
# The background task was dispatched instead of a synchronous import.
assert not Subscription.objects.filter(user=alice).exists()
@pytest.mark.django_db
def test_export_opml_view_returns_downloadable_file(client, alice, alices_subscription):
client.login(username="alice", password="pw-alice-123")
response = client.get(reverse("feeds:export_opml"))
assert response.status_code == 200
assert response["Content-Type"] == "text/x-opml"
assert "attachment" in response["Content-Disposition"]
assert b"example.com/feed.xml" in response.content
@pytest.mark.django_db
def test_import_opml_task_runs_import(alice):
from .tasks import import_opml_task
result = import_opml_task(alice.id, SIMPLE_OPML.decode("utf-8"))
assert result["created"] == 2
assert Subscription.objects.filter(user=alice).count() == 2