Private
Public Access
UserArticleState.is_starred/is_saved_for_later/starred_at are gone — starring and saving now add/remove an ArticleTag against a per-user "Starred" / "Saved for later" Tag, created lazily on first use and marked Tag.is_system=True. is_read/is_hidden stay on UserArticleState since they're genuine reading state, not categorization, which is what made these two candidates for unifying into the general tag mechanism. System tags are excluded from the Manage Tags page and from delete_tag (get_object_or_404 now requires is_system=False, so attempting to delete one 404s) and from the subscription-tag autocomplete, since they categorize articles, not feeds. The star/save icons are still exactly where they were — this only changes what powers them. apps.rules.engine's star action now does get_system_tag + ArticleTag. get_or_create instead of setting a boolean field. A data migration converts every existing is_starred=True/is_saved_for_later=True row into its ArticleTag equivalent before the fields are dropped — verified by seeding the pre-removal schema directly (including a row with both flags set) and confirming the migration produces the right tags. apps.articles.queries.with_user_state gained one more query (tag lookup for the current page's articles) to stay in the same "fixed number of queries regardless of article count" shape it already had. Verified end to end against a running dev server: toggling star/saved, the starred/saved filters, the sidebar's Favourites count, and that the Starred tag doesn't appear on the Manage Tags page. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
163 lines
5.2 KiB
Python
163 lines
5.2 KiB
Python
import pytest
|
|
from django.contrib.auth import get_user_model
|
|
from django.urls import reverse
|
|
|
|
from apps.articles.models import STARRED_TAG_NAME, Article, ArticleTag, UserArticleState
|
|
from apps.feeds.models import Feed, Subscription
|
|
|
|
from .models import FilterRule
|
|
from .tasks import reapply_rules_for_user_backlog
|
|
|
|
User = get_user_model()
|
|
|
|
|
|
def is_starred(user, article):
|
|
return ArticleTag.objects.filter(
|
|
user=user, article=article, tag__is_system=True, tag__name=STARRED_TAG_NAME
|
|
).exists()
|
|
|
|
|
|
@pytest.fixture
|
|
def alice(db):
|
|
return User.objects.create_user("alice", password="pw-alice-123")
|
|
|
|
|
|
@pytest.fixture
|
|
def bob(db):
|
|
return User.objects.create_user("bob", password="pw-bob-123")
|
|
|
|
|
|
@pytest.fixture
|
|
def feed(db):
|
|
return Feed.objects.create(feed_url="https://example.com/feed.xml", title="Example Feed")
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_create_rule(client, alice, feed):
|
|
Subscription.objects.create(user=alice, feed=feed)
|
|
client.login(username="alice", password="pw-alice-123")
|
|
|
|
response = client.post(
|
|
reverse("rules:create_rule"),
|
|
{
|
|
"match_field": FilterRule.FIELD_TITLE,
|
|
"match_type": FilterRule.MATCH_CONTAINS,
|
|
"match_value": "Python",
|
|
"action": FilterRule.ACTION_STAR,
|
|
"priority": 0,
|
|
"is_enabled": "on",
|
|
},
|
|
)
|
|
assert response.status_code == 302
|
|
assert FilterRule.objects.filter(user=alice, match_value="Python").exists()
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_tag_action_requires_action_value(client, alice):
|
|
client.login(username="alice", password="pw-alice-123")
|
|
response = client.post(
|
|
reverse("rules:create_rule"),
|
|
{
|
|
"match_field": FilterRule.FIELD_TITLE,
|
|
"match_type": FilterRule.MATCH_CONTAINS,
|
|
"match_value": "Python",
|
|
"action": FilterRule.ACTION_TAG,
|
|
"action_value": "",
|
|
"priority": 0,
|
|
},
|
|
)
|
|
assert response.status_code == 200
|
|
assert not FilterRule.objects.exists()
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_user_cannot_edit_another_users_rule(client, alice, bob):
|
|
rule = FilterRule.objects.create(
|
|
user=alice,
|
|
match_field=FilterRule.FIELD_TITLE,
|
|
match_type=FilterRule.MATCH_CONTAINS,
|
|
match_value="Python",
|
|
action=FilterRule.ACTION_STAR,
|
|
)
|
|
client.login(username="bob", password="pw-bob-123")
|
|
|
|
response = client.get(reverse("rules:edit_rule", args=[rule.pk]))
|
|
assert response.status_code == 404
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_delete_rule(client, alice):
|
|
rule = FilterRule.objects.create(
|
|
user=alice,
|
|
match_field=FilterRule.FIELD_TITLE,
|
|
match_type=FilterRule.MATCH_CONTAINS,
|
|
match_value="Python",
|
|
action=FilterRule.ACTION_STAR,
|
|
)
|
|
client.login(username="alice", password="pw-alice-123")
|
|
|
|
response = client.post(reverse("rules:delete_rule", args=[rule.pk]))
|
|
assert response.status_code == 302
|
|
assert not FilterRule.objects.filter(pk=rule.pk).exists()
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_reapply_rule_view_applies_to_unread_backlog(client, alice, feed):
|
|
Subscription.objects.create(user=alice, feed=feed)
|
|
article = Article.objects.create(feed=feed, guid="guid-1", title="Python 4 released")
|
|
rule = FilterRule.objects.create(
|
|
user=alice,
|
|
match_field=FilterRule.FIELD_TITLE,
|
|
match_type=FilterRule.MATCH_CONTAINS,
|
|
match_value="Python",
|
|
action=FilterRule.ACTION_STAR,
|
|
)
|
|
client.login(username="alice", password="pw-alice-123")
|
|
|
|
response = client.post(reverse("rules:reapply_rule", args=[rule.pk]))
|
|
assert response.status_code == 302
|
|
assert is_starred(alice, article) is True
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_reapply_skips_already_read_articles(alice, feed):
|
|
article = Article.objects.create(feed=feed, guid="guid-1", title="Python 4 released")
|
|
Subscription.objects.create(user=alice, feed=feed)
|
|
UserArticleState.objects.create(user=alice, article=article, is_read=True)
|
|
rule = FilterRule.objects.create(
|
|
user=alice,
|
|
match_field=FilterRule.FIELD_TITLE,
|
|
match_type=FilterRule.MATCH_CONTAINS,
|
|
match_value="Python",
|
|
action=FilterRule.ACTION_STAR,
|
|
)
|
|
|
|
count = reapply_rules_for_user_backlog(rule.pk)
|
|
|
|
assert count == 0
|
|
assert is_starred(alice, article) is False
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_reapply_respects_feed_scope(alice):
|
|
feed_a = Feed.objects.create(feed_url="https://a.example.com/feed.xml")
|
|
feed_b = Feed.objects.create(feed_url="https://b.example.com/feed.xml")
|
|
Subscription.objects.create(user=alice, feed=feed_a)
|
|
Subscription.objects.create(user=alice, feed=feed_b)
|
|
article_a = Article.objects.create(feed=feed_a, guid="guid-1", title="Python in A")
|
|
article_b = Article.objects.create(feed=feed_b, guid="guid-2", title="Python in B")
|
|
|
|
rule = FilterRule.objects.create(
|
|
user=alice,
|
|
feed=feed_a,
|
|
match_field=FilterRule.FIELD_TITLE,
|
|
match_type=FilterRule.MATCH_CONTAINS,
|
|
match_value="Python",
|
|
action=FilterRule.ACTION_STAR,
|
|
)
|
|
|
|
reapply_rules_for_user_backlog(rule.pk)
|
|
|
|
assert is_starred(alice, article_a) is True
|
|
assert not UserArticleState.objects.filter(user=alice, article=article_b).exists()
|