Private
Public Access
The setup view's User.objects.exists() check and the admin account's save() weren't in the same transaction, so two concurrent requests during first deployment could both pass the check and both create an admin account. SetupLock is a singleton row (pk=1); claiming it and creating the admin now happen in one atomic block, so only the first of any racing requests can succeed — the rest hit IntegrityError and are sent to the login page instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
141 lines
4.6 KiB
Python
141 lines
4.6 KiB
Python
import pytest
|
|
from django.urls import reverse
|
|
|
|
from .models import SetupLock, User
|
|
|
|
# SetupWizardMiddleware's cache is reset around every test by the autouse
|
|
# fixture in the top-level conftest.py, not just here.
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_root_redirects_to_setup_when_no_users_exist(client):
|
|
response = client.get("/", follow=False)
|
|
assert response.status_code == 302
|
|
assert response.url == reverse("accounts:setup")
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_pwa_routes_bypass_the_setup_redirect(client):
|
|
for url_name in ["pwa:manifest", "pwa:service_worker", "pwa:offline"]:
|
|
response = client.get(reverse(url_name))
|
|
assert response.status_code == 200, url_name
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_setup_creates_admin_and_logs_in(client):
|
|
response = client.post(
|
|
reverse("accounts:setup"),
|
|
{
|
|
"username": "keith",
|
|
"email": "keith@example.com",
|
|
"password": "correct-horse-battery",
|
|
"password_confirm": "correct-horse-battery",
|
|
},
|
|
)
|
|
assert response.status_code == 302
|
|
assert response.url == reverse("reader:stream")
|
|
|
|
user = User.objects.get(username="keith")
|
|
assert user.is_staff
|
|
assert user.is_superuser
|
|
|
|
stream_response = client.get(reverse("reader:stream"))
|
|
assert stream_response.status_code == 200
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_setup_refuses_a_second_concurrent_submission(client):
|
|
# Simulates two requests racing the setup form: the first claims the
|
|
# SetupLock row directly (standing in for a request that's already
|
|
# past the User.objects.exists() check), so a second submission's
|
|
# INSERT must lose instead of also creating an admin account.
|
|
SetupLock.objects.create()
|
|
|
|
response = client.post(
|
|
reverse("accounts:setup"),
|
|
{
|
|
"username": "raced",
|
|
"email": "raced@example.com",
|
|
"password": "correct-horse-battery",
|
|
"password_confirm": "correct-horse-battery",
|
|
},
|
|
)
|
|
assert response.status_code == 302
|
|
assert response.url == reverse("accounts:login")
|
|
assert not User.objects.filter(username="raced").exists()
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_setup_is_unreachable_once_a_user_exists(client):
|
|
User.objects.create_user("existing", password="irrelevant")
|
|
|
|
response = client.get(reverse("accounts:setup"))
|
|
assert response.status_code == 302
|
|
assert response.url == reverse("accounts:login")
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_setup_rejects_mismatched_passwords(client):
|
|
response = client.post(
|
|
reverse("accounts:setup"),
|
|
{
|
|
"username": "keith",
|
|
"email": "keith@example.com",
|
|
"password": "correct-horse-battery",
|
|
"password_confirm": "does-not-match",
|
|
},
|
|
)
|
|
assert response.status_code == 200
|
|
assert not User.objects.exists()
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_logout_via_post_logs_the_user_out(client):
|
|
User.objects.create_user("keith", password="pw-keith-123")
|
|
client.login(username="keith", password="pw-keith-123")
|
|
|
|
response = client.post(reverse("accounts:logout"))
|
|
assert response.status_code == 302
|
|
|
|
stream_response = client.get(reverse("reader:stream"))
|
|
assert stream_response.status_code == 302
|
|
assert stream_response.url.startswith(reverse("accounts:login"))
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_logout_rejects_get(client):
|
|
# Django's LogoutView only accepts POST (see templates/core/_sidebar.html,
|
|
# which submits it as a form rather than a plain link).
|
|
User.objects.create_user("keith", password="pw-keith-123")
|
|
client.login(username="keith", password="pw-keith-123")
|
|
|
|
response = client.get(reverse("accounts:logout"))
|
|
assert response.status_code == 405
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_non_admin_cannot_manage_users(client):
|
|
User.objects.create_user("regular", password="pw-regular-123")
|
|
client.login(username="regular", password="pw-regular-123")
|
|
|
|
response = client.get(reverse("accounts:manage_users"))
|
|
assert response.status_code == 302 # user_passes_test redirects non-staff
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_admin_can_create_user(client):
|
|
admin = User.objects.create_user("admin", password="pw-admin-123", is_staff=True)
|
|
client.login(username="admin", password="pw-admin-123")
|
|
|
|
response = client.post(
|
|
reverse("accounts:create_user"),
|
|
{
|
|
"username": "newperson",
|
|
"email": "newperson@example.com",
|
|
"password": "pw-newperson-123",
|
|
},
|
|
)
|
|
assert response.status_code == 302
|
|
assert User.objects.filter(username="newperson").exists()
|
|
assert admin.pk # sanity: fixture user untouched
|