Private
Public Access
Ingestion did a get_or_create per entry. It now prefetches existing articles for the poll in one query, bulk-inserts new ones and bulk-updates changed ones (falling back to row-by-row only if a concurrent fetch wins a race), and dispatches rule evaluation in bounded chunks so a huge first fetch is several small tasks. /health/ stays a DB-only liveness check (upgrade.sh gates on it right after restart). New /health/ready/ also checks Redis and that poll_due_feeds ticked within five minutes — proving beat and a worker are both alive — and returns 503 with per-check detail otherwise. The sidebar unread-count cache and login throttle now degrade instead of erroring when Redis is unreachable: every authenticated page and every login would otherwise 500 during a cache outage. Found while verifying in a sandbox with no Redis. Also includes the dashboard's oldest-article metric (core/views.py). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
93 lines
3.1 KiB
Python
93 lines
3.1 KiB
Python
import pytest
|
|
from django.contrib.auth import get_user_model
|
|
from django.core.cache import cache
|
|
from django.urls import reverse
|
|
|
|
from .views import (
|
|
LOGIN_RATE_LIMIT_MAX_ATTEMPTS_PER_ADDRESS,
|
|
LOGIN_RATE_LIMIT_MAX_ATTEMPTS_PER_USERNAME,
|
|
)
|
|
|
|
User = get_user_model()
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _clear_rate_limit_cache():
|
|
cache.clear()
|
|
yield
|
|
cache.clear()
|
|
|
|
|
|
@pytest.fixture
|
|
def alice(db):
|
|
return User.objects.create_user("alice", password="pw-alice-123")
|
|
|
|
|
|
def _bad_login(client, username="alice"):
|
|
return client.post(reverse("accounts:login"), {"username": username, "password": "wrong"})
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_a_single_failed_login_still_shows_the_normal_error(client, alice):
|
|
response = _bad_login(client)
|
|
assert response.status_code == 200
|
|
assert b"Please enter a correct" in response.content or response.context["form"].errors
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_correct_credentials_succeed_before_the_limit_is_hit(client, alice):
|
|
for _ in range(3):
|
|
_bad_login(client)
|
|
|
|
response = client.post(
|
|
reverse("accounts:login"), {"username": "alice", "password": "pw-alice-123"}
|
|
)
|
|
assert response.status_code == 302
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_too_many_failed_attempts_from_one_address_blocks_further_tries(client, alice):
|
|
for _ in range(LOGIN_RATE_LIMIT_MAX_ATTEMPTS_PER_ADDRESS):
|
|
_bad_login(client)
|
|
|
|
# Even the correct password is now refused — the throttle runs
|
|
# before the form is ever validated.
|
|
response = client.post(
|
|
reverse("accounts:login"), {"username": "alice", "password": "pw-alice-123"}
|
|
)
|
|
assert response.status_code == 302
|
|
assert response.url == reverse("accounts:login")
|
|
assert not response.wsgi_request.user.is_authenticated
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_too_many_failed_attempts_against_one_username_blocks_that_username(client, alice):
|
|
bob = User.objects.create_user("bob", password="pw-bob-123")
|
|
|
|
for _ in range(LOGIN_RATE_LIMIT_MAX_ATTEMPTS_PER_USERNAME):
|
|
_bad_login(client, username="alice")
|
|
|
|
# Same client address, different username — the per-username
|
|
# throttle for "alice" shouldn't affect bob logging in.
|
|
response = client.post(reverse("accounts:login"), {"username": "bob", "password": "pw-bob-123"})
|
|
assert response.status_code == 302
|
|
assert response.wsgi_request.user == bob
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_login_still_works_when_the_throttle_cache_is_down(client, monkeypatch):
|
|
from unittest.mock import Mock
|
|
|
|
from django.contrib.auth import get_user_model
|
|
|
|
get_user_model().objects.create_user("alice", password="pw-alice-123")
|
|
broken = Mock(side_effect=ConnectionError("redis down"))
|
|
monkeypatch.setattr("apps.accounts.views.cache.get", broken)
|
|
monkeypatch.setattr("apps.accounts.views.cache.incr", broken)
|
|
monkeypatch.setattr("apps.accounts.views.cache.set", broken)
|
|
|
|
bad = client.post(reverse("accounts:login"), {"username": "alice", "password": "wrong"})
|
|
assert bad.status_code == 200
|
|
good = client.post(reverse("accounts:login"), {"username": "alice", "password": "pw-alice-123"})
|
|
assert good.status_code == 302
|