Private
Public Access
Folders are gone — organization is tags-only, via the SubscriptionTag model added last commit. A migration converts every existing Folder into a same-named Tag applied to its feeds, and every folder-scoped FilterRule into an equivalent tag-scoped one, before the Folder table is dropped, so upgrading an existing instance loses nothing (verified by seeding the pre-removal schema directly and running the migration chain against it). Unlike folders, a feed can carry more than one tag, so: - apps.articles.tasks.apply_filter_rules_for_feed and apps.rules.tasks's backlog re-apply now scope by "does this feed carry tag X" rather than "does this feed belong to folder X". - apps.feeds.opml: a feed's tags export as a comma-separated "category" attribute (the standard OPML way to represent multiple categories) instead of nesting under one folder outline. Import reads both that attribute and nested category outlines, turning each enclosing level into its own tag rather than collapsing to the nearest one. - The sidebar groups feeds by tag instead of folder, so a feed with two tags now appears in both groups; untagged feeds fall into "Untagged". AddFeedForm gained a comma-separated tag_names field for parity with the old add-time folder picker. EditSubscriptionForm dropped its folder field entirely — tagging a subscription happens through the tag editor already on that page. Verified end to end: the migration chain from empty, the data migration against a seeded pre-removal schema (folder/subscription/rule all convert correctly), and the running app's sidebar grouping, OPML export category attributes, and tag editor. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
192 lines
6.6 KiB
Python
192 lines
6.6 KiB
Python
import pytest
|
|
from django.contrib.auth import get_user_model
|
|
from django.core.files.uploadedfile import SimpleUploadedFile
|
|
from django.urls import reverse
|
|
|
|
from .models import Feed, Subscription
|
|
from .test_opml import SIMPLE_OPML
|
|
|
|
User = get_user_model()
|
|
|
|
|
|
@pytest.fixture
|
|
def alice(db):
|
|
return User.objects.create_user("alice", password="pw-alice-123")
|
|
|
|
|
|
@pytest.fixture
|
|
def bob(db):
|
|
return User.objects.create_user("bob", password="pw-bob-123")
|
|
|
|
|
|
@pytest.fixture
|
|
def alices_subscription(alice):
|
|
feed = Feed.objects.create(feed_url="https://example.com/feed.xml", title="Example")
|
|
return Subscription.objects.create(user=alice, feed=feed)
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_subscription_list_requires_login(client):
|
|
response = client.get(reverse("feeds:subscription_list"))
|
|
assert response.status_code == 302
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_subscription_list_shows_only_own_subscriptions(client, alice, bob, alices_subscription):
|
|
client.login(username="bob", password="pw-bob-123")
|
|
response = client.get(reverse("feeds:subscription_list"))
|
|
assert "Example" not in response.content.decode()
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_edit_subscription_updates_title(client, alice, alices_subscription):
|
|
client.login(username="alice", password="pw-alice-123")
|
|
|
|
response = client.post(
|
|
reverse("feeds:edit_subscription", args=[alices_subscription.pk]),
|
|
{"custom_title": "My Example Feed"},
|
|
)
|
|
|
|
assert response.status_code == 302
|
|
alices_subscription.refresh_from_db()
|
|
assert alices_subscription.custom_title == "My Example Feed"
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_user_cannot_edit_another_users_subscription(client, alice, bob, alices_subscription):
|
|
client.login(username="bob", password="pw-bob-123")
|
|
response = client.get(reverse("feeds:edit_subscription", args=[alices_subscription.pk]))
|
|
assert response.status_code == 404
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_add_tag_to_subscription_creates_tag_and_link(client, alice, alices_subscription):
|
|
from apps.articles.models import SubscriptionTag, Tag
|
|
|
|
client.login(username="alice", password="pw-alice-123")
|
|
|
|
response = client.post(
|
|
reverse("feeds:add_tag_to_subscription", args=[alices_subscription.pk]),
|
|
{"tag_name": "backend"},
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
tag = Tag.objects.get(user=alice, name="backend")
|
|
assert SubscriptionTag.objects.filter(
|
|
user=alice, subscription=alices_subscription, tag=tag
|
|
).exists()
|
|
assert b"backend" in response.content
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_remove_tag_from_subscription(client, alice, alices_subscription):
|
|
from apps.articles.models import SubscriptionTag, Tag
|
|
|
|
client.login(username="alice", password="pw-alice-123")
|
|
tag = Tag.objects.create(user=alice, name="backend")
|
|
SubscriptionTag.objects.create(user=alice, subscription=alices_subscription, tag=tag)
|
|
|
|
response = client.post(
|
|
reverse("feeds:remove_tag_from_subscription", args=[alices_subscription.pk, tag.pk])
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
assert not SubscriptionTag.objects.filter(
|
|
user=alice, subscription=alices_subscription, tag=tag
|
|
).exists()
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_user_cannot_tag_another_users_subscription(client, alice, bob, alices_subscription):
|
|
client.login(username="bob", password="pw-bob-123")
|
|
response = client.post(
|
|
reverse("feeds:add_tag_to_subscription", args=[alices_subscription.pk]),
|
|
{"tag_name": "backend"},
|
|
)
|
|
assert response.status_code == 404
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_unsubscribe(client, alice, alices_subscription):
|
|
client.login(username="alice", password="pw-alice-123")
|
|
response = client.post(reverse("feeds:unsubscribe", args=[alices_subscription.pk]))
|
|
assert response.status_code == 302
|
|
assert not Subscription.objects.filter(pk=alices_subscription.pk).exists()
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_user_cannot_unsubscribe_another_users_subscription(
|
|
client, alice, bob, alices_subscription
|
|
):
|
|
client.login(username="bob", password="pw-bob-123")
|
|
response = client.post(reverse("feeds:unsubscribe", args=[alices_subscription.pk]))
|
|
assert response.status_code == 404
|
|
assert Subscription.objects.filter(pk=alices_subscription.pk).exists()
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_import_opml_view_creates_subscriptions(client, alice):
|
|
client.login(username="alice", password="pw-alice-123")
|
|
upload = SimpleUploadedFile("subs.opml", SIMPLE_OPML, content_type="text/x-opml")
|
|
|
|
response = client.post(reverse("feeds:import_opml"), {"opml_file": upload})
|
|
|
|
assert response.status_code == 302
|
|
assert Subscription.objects.filter(user=alice).count() == 2
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_import_opml_view_rejects_malformed_file(client, alice):
|
|
client.login(username="alice", password="pw-alice-123")
|
|
upload = SimpleUploadedFile("subs.opml", b"not xml at all", content_type="text/x-opml")
|
|
|
|
response = client.post(reverse("feeds:import_opml"), {"opml_file": upload})
|
|
|
|
assert response.status_code == 302
|
|
assert not Subscription.objects.filter(user=alice).exists()
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_import_opml_dispatches_background_task_above_threshold(client, alice, monkeypatch):
|
|
client.login(username="alice", password="pw-alice-123")
|
|
|
|
dispatched = {}
|
|
|
|
def fake_delay(user_id, content):
|
|
dispatched["user_id"] = user_id
|
|
dispatched["content"] = content
|
|
|
|
from . import views as feeds_views
|
|
|
|
monkeypatch.setattr(feeds_views.import_opml_task, "delay", fake_delay)
|
|
monkeypatch.setattr(feeds_views, "OPML_ASYNC_THRESHOLD", 1)
|
|
|
|
upload = SimpleUploadedFile("subs.opml", SIMPLE_OPML, content_type="text/x-opml")
|
|
response = client.post(reverse("feeds:import_opml"), {"opml_file": upload})
|
|
|
|
assert response.status_code == 302
|
|
assert dispatched["user_id"] == alice.id
|
|
# The background task was dispatched instead of a synchronous import.
|
|
assert not Subscription.objects.filter(user=alice).exists()
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_export_opml_view_returns_downloadable_file(client, alice, alices_subscription):
|
|
client.login(username="alice", password="pw-alice-123")
|
|
response = client.get(reverse("feeds:export_opml"))
|
|
|
|
assert response.status_code == 200
|
|
assert response["Content-Type"] == "text/x-opml"
|
|
assert "attachment" in response["Content-Disposition"]
|
|
assert b"example.com/feed.xml" in response.content
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_import_opml_task_runs_import(alice):
|
|
from .tasks import import_opml_task
|
|
|
|
result = import_opml_task(alice.id, SIMPLE_OPML.decode("utf-8"))
|
|
|
|
assert result["created"] == 2
|
|
assert Subscription.objects.filter(user=alice).count() == 2
|