Files
ksmithandClaude Sonnet 5.5 70b0d4f277 Index Postgres search and harden SQLite search/concurrency (C5, C6)
Postgres recomputed a tsvector over every article's full text on every
search. A migration now adds a stored, GIN-indexed search_vector column
kept current by a trigger (so no ingest/update path can forget it), and
the backend reads that column. Untested here: no Postgres in the dev
sandbox, so the SQL is reviewed but not executed — worth one run of the
(skipped-on-SQLite) Postgres test module against a real instance.

SQLite search built one bound parameter per subscribed feed, so enough
feeds would exceed the variable limit, and the OperationalError was
swallowed into "no results". It now scopes through a subquery on
Subscription and logs failures. SQLite connections also get WAL mode,
a 20s busy timeout, and IMMEDIATE transactions so gunicorn, Celery, and
the FTS triggers stop tripping over each other.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-01 08:51:20 -07:00

55 lines
2.0 KiB
Python

import logging
import sqlite3
from django.db import connection
from apps.articles.models import Article
from .base import SearchBackend
logger = logging.getLogger(__name__)
def _fts_phrase_query(raw_query: str) -> str:
"""Wraps the whole user input as a single FTS5 phrase so arbitrary
punctuation (hyphens, quotes, parentheses...) in a search box doesn't
blow up as invalid FTS5 query syntax."""
escaped = raw_query.replace('"', '""')
return f'"{escaped}"'
class SQLiteFTSBackend(SearchBackend):
def search(self, query: str, user, limit: int = 50):
if not query.strip():
return []
# Scoped through a subquery on Subscription rather than an IN
# list built from every subscribed feed id (C6): a user with
# thousands of feeds would otherwise exceed SQLite's bound-
# parameter limit and the whole search would fail.
sql = """
SELECT a.id
FROM articles_article a
JOIN articles_fts f ON f.rowid = a.id
WHERE articles_fts MATCH %s
AND a.feed_id IN (SELECT feed_id FROM feeds_subscription WHERE user_id = %s)
ORDER BY rank
LIMIT %s
"""
try:
with connection.cursor() as cursor:
cursor.execute(sql, [_fts_phrase_query(query), user.pk, limit])
ordered_ids = [row[0] for row in cursor.fetchall()]
except sqlite3.OperationalError:
# A genuinely bad FTS query is rare (the input is quoted as a
# phrase), so this is far more likely a real operational
# failure — log it instead of silently showing "no results".
logger.exception("SQLite FTS search failed for user %s", user.pk)
return []
if not ordered_ids:
return []
articles_by_id = Article.objects.select_related("feed").in_bulk(ordered_ids)
return [articles_by_id[pk] for pk in ordered_ids if pk in articles_by_id]