Files
ksmithandClaude Sonnet 5.5 ac5e951749 Harden the login throttle and cache readiness aggregates (R2-S4, R2-C5; #36, #45)
S4: the throttle keyed on the first X-Forwarded-For entry, which a client
or a proxy that appends can choose, and disabled itself entirely when
Redis was down.

EVECTION_TRUSTED_PROXIES (IPs/CIDRs of your reverse proxy) makes it
strict: X-Forwarded-For is only believed when the TCP peer is a trusted
proxy, and the rightmost entry that isn't itself a trusted proxy — the
address the proxy actually saw — is used instead of the spoofable first
one. Unset keeps the previous behavior so existing installs don't
suddenly share one bucket behind a proxy, and `manage.py check --deploy`
warns (evection.W001) until it's set. During a Redis outage the throttle
now falls back to a bounded in-process limiter instead of switching off.

C5: /health/ready/ reuses its queue/feed aggregates for 15s
(EVECTION_HEALTH_CACHE_SECONDS) so a fast-polling monitor can't create
steady load; the database, Redis and poller probes stay live. Docs
cover both settings, restricting the endpoint at the proxy, and the
tombstone/purge behavior from the previous changes.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-01 12:08:13 -07:00

21 lines
765 B
Python

from django.conf import settings
from django.core.checks import Tags, Warning, register
@register(Tags.security, deploy=True)
def trusted_proxies_configured(app_configs, **kwargs):
if settings.DEBUG or settings.EVECTION_TRUSTED_PROXIES:
return []
return [
Warning(
"EVECTION_TRUSTED_PROXIES is not set.",
hint=(
"The login throttle then trusts the first X-Forwarded-For entry from "
"anyone, which only holds while gunicorn is reachable by nothing but a "
"proxy that overwrites that header. Set EVECTION_TRUSTED_PROXIES to your "
"reverse proxy's IP/CIDR in .env (see docs/install.md)."
),
id="evection.W001",
)
]