DarkSingularity/orbithub
Internal
Public Access
0
0
Fork 0
Code Issues 2 Pull Requests Packages Projects Releases 6 Wiki Activity

macOS build was a bare Mach-O binary, not a proper .app bundle (no Finder icon) #16

New Issue
Closed
opened 2026-09-08 12:42:18 -06:00 by Agent · 0 comments
Agent commented 2026-09-08 12:42:18 -06:00
Owner
Copy Link
Copy Source

Same root cause as the earlier Windows exe icon issue: add_executable() never set MACOSX_BUNDLE, so the macOS build produced a bare Mach-O binary rather than a proper .app bundle. Without a bundle there's no Info.plist/.icns mechanism at all for Finder to show a custom icon.

Fixed across three commits:

  • ac3cebc: added packaging/macos/orbithub.icns (rendered up to 1024px from the same createOrbitHubAppIcon() logic used at runtime) and wired MACOSX_BUNDLE + MACOSX_BUNDLE_ICON_FILE into CMake. Build output moves from build/orbithub to build/orbithub.app (launch with open build/orbithub.app); docs/BUILDING.md updated.
  • 49ee12f: fixed a CMake configure error (install(TARGETS) needs an explicit BUNDLE DESTINATION for a MACOSX_BUNDLE target).
  • 9d88b74: the first .icns (written via Pillow) didn't actually render in Finder (showed the generic "unavailable" placeholder) -- rebuilt by hand using Apple's documented icns binary format directly instead of relying on Pillow's ICNS encoder.

None of this affects where existing profiles/database live, since that uses QStandardPaths::AppDataLocation, not the executable's own path. Confirmed fixed: .app bundle builds and shows the correct icon in Finder.

Same root cause as the earlier Windows exe icon issue: `add_executable()` never set `MACOSX_BUNDLE`, so the macOS build produced a bare Mach-O binary rather than a proper `.app` bundle. Without a bundle there's no `Info.plist`/`.icns` mechanism at all for Finder to show a custom icon. Fixed across three commits: - ac3cebc: added `packaging/macos/orbithub.icns` (rendered up to 1024px from the same `createOrbitHubAppIcon()` logic used at runtime) and wired `MACOSX_BUNDLE` + `MACOSX_BUNDLE_ICON_FILE` into CMake. Build output moves from `build/orbithub` to `build/orbithub.app` (launch with `open build/orbithub.app`); docs/BUILDING.md updated. - 49ee12f: fixed a CMake configure error (`install(TARGETS)` needs an explicit `BUNDLE DESTINATION` for a `MACOSX_BUNDLE` target). - 9d88b74: the first `.icns` (written via Pillow) didn't actually render in Finder (showed the generic "unavailable" placeholder) -- rebuilt by hand using Apple's documented icns binary format directly instead of relying on Pillow's ICNS encoder. None of this affects where existing profiles/database live, since that uses `QStandardPaths::AppDataLocation`, not the executable's own path. Confirmed fixed: `.app` bundle builds and shows the correct icon in Finder.
Agent closed this issue 2026-09-08 12:42:22 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Agent deployment ksmith
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DarkSingularity/orbithub#16