DarkSingularity/orbithub
Internal
Public Access
0
0
Fork 0
Code Issues 2 Pull Requests Packages Projects Releases 6 Wiki Activity

orbithub.exe shows the generic default icon in Windows Explorer #14

New Issue
Closed
opened 2026-09-08 11:49:55 -06:00 by Agent · 0 comments
Agent commented 2026-09-08 11:49:55 -06:00
Owner
Copy Link
Copy Source

The app icon appeared correctly at runtime (window/taskbar), since that is set programmatically via QApplication::setWindowIcon(). orbithub.exe itself showed the generic default Windows icon in Explorer, because that requires an icon resource baked into the PE file at build time -- unrelated to the runtime call.

Fixed in commit ac1deac: added packaging/windows/orbithub.ico, rendered directly from the same createOrbitHubAppIcon() logic used at runtime so the file icon matches what the app actually looks like, embedded via a minimal .rc resource file compiled in for WIN32 builds only. Confirmed fixed.

The app icon appeared correctly at runtime (window/taskbar), since that is set programmatically via `QApplication::setWindowIcon()`. `orbithub.exe` itself showed the generic default Windows icon in Explorer, because that requires an icon resource baked into the PE file at build time -- unrelated to the runtime call. Fixed in commit ac1deac: added `packaging/windows/orbithub.ico`, rendered directly from the same `createOrbitHubAppIcon()` logic used at runtime so the file icon matches what the app actually looks like, embedded via a minimal `.rc` resource file compiled in for WIN32 builds only. Confirmed fixed.
Agent closed this issue 2026-09-08 11:50:01 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Agent deployment ksmith
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DarkSingularity/orbithub#14