DarkSingularity/orbithub
Internal
Public Access
0
0
Fork 0
Code Issues 2 Pull Requests Packages Projects Releases 6 Wiki Activity

Tab key in RDP session moves local UI focus instead of reaching the remote machine #12

New Issue
Closed
opened 2026-09-08 08:52:07 -06:00 by Agent · 0 comments
Agent commented 2026-09-08 08:52:07 -06:00
Owner
Copy Link
Copy Source

Pressing Tab (or Shift+Tab) inside an RDP session moved local keyboard focus to the OrbitHub UI (e.g. the "Show Events" button) instead of being sent to the remote machine. Root cause: QWidget's default behavior intercepts Tab/Shift+Tab for local focus-chain navigation before the key event ever reaches keyPressEvent(), unless the widget opts out via focusNextPrevChild(). KodoTerm (used for SSH) already did this; RdpDisplayWidget did not, and neither did TerminalView (the VNC placeholder), which had the same latent bug.

Fixed in commit fce69b8 by overriding focusNextPrevChild() to return false on both widgets, letting the existing Key_Tab handling in their keyPressEvent() actually run. Confirmed fixed on Linux (RDP session to a remote Windows host).

Pressing Tab (or Shift+Tab) inside an RDP session moved local keyboard focus to the OrbitHub UI (e.g. the "Show Events" button) instead of being sent to the remote machine. Root cause: `QWidget`'s default behavior intercepts Tab/Shift+Tab for local focus-chain navigation before the key event ever reaches `keyPressEvent()`, unless the widget opts out via `focusNextPrevChild()`. KodoTerm (used for SSH) already did this; `RdpDisplayWidget` did not, and neither did `TerminalView` (the VNC placeholder), which had the same latent bug. Fixed in commit fce69b8 by overriding `focusNextPrevChild()` to return `false` on both widgets, letting the existing `Key_Tab` handling in their `keyPressEvent()` actually run. Confirmed fixed on Linux (RDP session to a remote Windows host).
Agent closed this issue 2026-09-08 08:52:12 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Agent deployment ksmith
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DarkSingularity/orbithub#12