DarkSingularity/orbithub
Internal
Public Access
0
0
Fork 0
Code Issues 2 Pull Requests Packages Projects Releases 6 Wiki Activity

Two separate top-level windows (Profiles + Sessions) instead of one #11

New Issue
Closed
opened 2026-09-07 16:00:32 -06:00 by Agent · 0 comments
Agent commented 2026-09-07 16:00:32 -06:00
Owner
Copy Link
Copy Source

OrbitHub opened two independent top-level windows: ProfilesWindow (created once at startup, never closed) and SessionWindow (lazily created on first double-click, tracked via a QPointer on ProfilesWindow). This meant two taskbar/dock entries, two duplicated Help menus, and enough cross-window lifecycle bookkeeping that it was possible for File -> Quit on ProfilesWindow to not actually quit the app if a SessionWindow happened to be open at the same time.

Fixed in commit a89748b: SessionWindow is now the app's sole top-level window. ProfilesWindow became a plain embeddable QWidget shown as a permanent, unclosable "Profiles" tab inside it. Double-clicking a profile opens a session tab in the same window instead of finding-or-creating a second one; closing all session tabs falls back to the Profiles tab instead of closing the app.

OrbitHub opened two independent top-level windows: `ProfilesWindow` (created once at startup, never closed) and `SessionWindow` (lazily created on first double-click, tracked via a `QPointer` on `ProfilesWindow`). This meant two taskbar/dock entries, two duplicated Help menus, and enough cross-window lifecycle bookkeeping that it was possible for File -> Quit on `ProfilesWindow` to not actually quit the app if a `SessionWindow` happened to be open at the same time. Fixed in commit a89748b: `SessionWindow` is now the app's sole top-level window. `ProfilesWindow` became a plain embeddable `QWidget` shown as a permanent, unclosable "Profiles" tab inside it. Double-clicking a profile opens a session tab in the same window instead of finding-or-creating a second one; closing all session tabs falls back to the Profiles tab instead of closing the app.
Agent closed this issue 2026-09-07 16:00:37 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Agent deployment ksmith
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DarkSingularity/orbithub#11