Private
Public Access
ksmithandClaude Sonnet 5
b26643527d
Replaces the stateless signed-cookie session (bare user_id) with a real server-side sessions table -- the cookie now just carries an opaque session id, resolved against the DB on every request. Each session records IP address (respects X-Forwarded-For), a parsed device label, and last-seen time (throttled updates, not written on every request). New GET/DELETE /api/auth/sessions endpoints and an "Active sessions" section in Profile settings let a user see every device they're logged in from and revoke one they don't recognize -- including their own current session, which just signs them out. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
93 lines
3.7 KiB
Python
93 lines
3.7 KiB
Python
import uuid
|
|
|
|
from fastapi import Depends, HTTPException, Request
|
|
from sqlalchemy import select
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
from sqlalchemy.orm import selectinload
|
|
|
|
from app.database import get_db
|
|
from app.models import RoomMembership, RoomRole, User
|
|
from app.services.bot_service import resolve_token
|
|
from app.services.session_service import resolve_session
|
|
|
|
_ROLE_RANK = {RoomRole.member: 0, RoomRole.admin: 1, RoomRole.owner: 2}
|
|
|
|
|
|
async def get_current_user(
|
|
request: Request, db: AsyncSession = Depends(get_db)
|
|
) -> User:
|
|
# Bearer token (bots) takes priority over the session cookie (humans) --
|
|
# a request either carries one or the other, never meaningfully both.
|
|
# Downstream, a token-authenticated bot is subject to the exact same
|
|
# room-membership/role checks as a session-authenticated human; the
|
|
# token additionally narrows what it can do via require_scope below.
|
|
auth_header = request.headers.get("authorization")
|
|
if auth_header and auth_header.lower().startswith("bearer "):
|
|
resolved = await resolve_token(db, auth_header[len("bearer ") :].strip())
|
|
if resolved is None:
|
|
raise HTTPException(status_code=401, detail="Invalid or revoked API token")
|
|
user, token = resolved
|
|
request.state.api_token = token
|
|
return user
|
|
|
|
session_id = request.session.get("session_id")
|
|
if not session_id:
|
|
raise HTTPException(status_code=401, detail="Not authenticated")
|
|
|
|
# #69: a session row, not a bare user_id -- resolve_session is also
|
|
# where a revoked session (this endpoint's own DELETE, or another
|
|
# device's "sign out") actually takes effect, since there's no other
|
|
# per-request check of that state.
|
|
session = await resolve_session(db, uuid.UUID(session_id))
|
|
if session is None:
|
|
request.session.clear()
|
|
raise HTTPException(status_code=401, detail="Not authenticated")
|
|
request.state.session_id = session.id
|
|
|
|
# Eager-loaded so UserRead.active_custom_theme (app/schemas/user.py) can
|
|
# be read without a MissingGreenlet -- selectinload skips the second
|
|
# query entirely when active_custom_theme_id is null (the common case),
|
|
# so this costs nothing for users who've never set a custom theme.
|
|
user = await db.get(
|
|
User, session.user_id, options=[selectinload(User.active_custom_theme)]
|
|
)
|
|
if user is None or not user.is_active:
|
|
request.session.clear()
|
|
raise HTTPException(status_code=401, detail="Not authenticated")
|
|
|
|
return user
|
|
|
|
|
|
def require_scope(request: Request, scope: str) -> None:
|
|
token = getattr(request.state, "api_token", None)
|
|
if token is not None and scope not in token.scopes:
|
|
raise HTTPException(status_code=403, detail=f"Token missing required scope: {scope}")
|
|
|
|
|
|
async def require_room_member(
|
|
room_id: uuid.UUID, user: User, db: AsyncSession
|
|
) -> RoomMembership:
|
|
result = await db.execute(
|
|
select(RoomMembership).where(
|
|
RoomMembership.room_id == room_id, RoomMembership.user_id == user.id
|
|
)
|
|
)
|
|
membership = result.scalar_one_or_none()
|
|
if membership is None:
|
|
raise HTTPException(status_code=403, detail="Not a member of this room")
|
|
return membership
|
|
|
|
|
|
async def require_room_role(
|
|
room_id: uuid.UUID, user: User, db: AsyncSession, minimum: RoomRole
|
|
) -> RoomMembership:
|
|
membership = await require_room_member(room_id, user, db)
|
|
if _ROLE_RANK[membership.role] < _ROLE_RANK[minimum]:
|
|
raise HTTPException(status_code=403, detail="Insufficient room role")
|
|
return membership
|
|
|
|
|
|
def require_site_admin(user: User) -> None:
|
|
if not user.is_site_admin:
|
|
raise HTTPException(status_code=403, detail="Site admin required")
|