Expand direct image links instead of showing nothing (#43 follow-up)

A URL that points straight at an image file (Content-Type: image/*) has
no HTML to scrape Open Graph tags from, so the fetch found nothing and
the message showed no preview at all -- reported against
https://imgs.xkcd.com/comics/creepy.png.

link_preview_service now recognizes an allowed image content-type (same
list storage.py uses for uploads) before falling through to the HTML/og:
path, and returns the URL itself as the preview (LinkPreview.is_image).
No need to download the body -- the already-SSRF-validated URL is the
image. The frontend renders that case as a real expandable image
(message-image + lightbox, same as an actual attachment) instead of the
small title+description card, which would have nothing to show anyway.

Verified end-to-end against the reported URL.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
2026-08-17 18:01:56 -06:00
co-authored by Claude Sonnet 5
parent 760d2cf5dd
commit 54932c9c03
9 changed files with 129 additions and 7 deletions
+3 -1
View File
@@ -172,7 +172,9 @@ export function MessageList({ roomId, messages, members, onEdit, onReact }: Mess
{msg.edited_at && <span className="message-edited"> (edited)</span>}
</div>
)}
{msg.link_preview && <LinkPreviewCard preview={msg.link_preview} />}
{msg.link_preview && (
<LinkPreviewCard preview={msg.link_preview} onImageClick={setLightboxSrc} />
)}
{msg.reactions.length > 0 && (
<div className="message-reaction-pills">
{msg.reactions.map((r) => {