Private
Public Access
Add adjustable text size and emoji size preferences (#71)
Text was too small on high-DPI screens with no in-app fix beyond browser zoom. Adds a text-size setting (scales the whole app via a root font-size percentage), auto-large rendering for emoji-only messages, and an independent emoji-size preference that also scales reaction pills without affecting the emoji picker's fixed-size grid. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,32 @@
|
||||
"""add user text_scale preference
|
||||
|
||||
Revision ID: 339b78011a4f
|
||||
Revises: a318850726ee
|
||||
Create Date: 2026-08-30 18:03:16.159924
|
||||
|
||||
"""
|
||||
from typing import Sequence, Union
|
||||
|
||||
from alembic import op
|
||||
import sqlalchemy as sa
|
||||
|
||||
|
||||
# revision identifiers, used by Alembic.
|
||||
revision: str = '339b78011a4f'
|
||||
down_revision: Union[str, Sequence[str], None] = 'a318850726ee'
|
||||
branch_labels: Union[str, Sequence[str], None] = None
|
||||
depends_on: Union[str, Sequence[str], None] = None
|
||||
|
||||
|
||||
def upgrade() -> None:
|
||||
"""Upgrade schema."""
|
||||
# ### commands auto generated by Alembic - please adjust! ###
|
||||
op.add_column('users', sa.Column('text_scale', sa.String(length=20), nullable=True))
|
||||
# ### end Alembic commands ###
|
||||
|
||||
|
||||
def downgrade() -> None:
|
||||
"""Downgrade schema."""
|
||||
# ### commands auto generated by Alembic - please adjust! ###
|
||||
op.drop_column('users', 'text_scale')
|
||||
# ### end Alembic commands ###
|
||||
@@ -0,0 +1,32 @@
|
||||
"""add user emoji_scale preference
|
||||
|
||||
Revision ID: e81c9bcc82b9
|
||||
Revises: 339b78011a4f
|
||||
Create Date: 2026-08-30 18:14:26.045186
|
||||
|
||||
"""
|
||||
from typing import Sequence, Union
|
||||
|
||||
from alembic import op
|
||||
import sqlalchemy as sa
|
||||
|
||||
|
||||
# revision identifiers, used by Alembic.
|
||||
revision: str = 'e81c9bcc82b9'
|
||||
down_revision: Union[str, Sequence[str], None] = '339b78011a4f'
|
||||
branch_labels: Union[str, Sequence[str], None] = None
|
||||
depends_on: Union[str, Sequence[str], None] = None
|
||||
|
||||
|
||||
def upgrade() -> None:
|
||||
"""Upgrade schema."""
|
||||
# ### commands auto generated by Alembic - please adjust! ###
|
||||
op.add_column('users', sa.Column('emoji_scale', sa.String(length=20), nullable=True))
|
||||
# ### end Alembic commands ###
|
||||
|
||||
|
||||
def downgrade() -> None:
|
||||
"""Downgrade schema."""
|
||||
# ### commands auto generated by Alembic - please adjust! ###
|
||||
op.drop_column('users', 'emoji_scale')
|
||||
# ### end Alembic commands ###
|
||||
@@ -19,6 +19,17 @@ class User(Base):
|
||||
is_active: Mapped[bool] = mapped_column(Boolean, default=True, nullable=False)
|
||||
display_name: Mapped[str | None] = mapped_column(String(50))
|
||||
theme: Mapped[str | None] = mapped_column(String(20))
|
||||
# #71: null means "normal" (the pre-existing default before this
|
||||
# setting existed) -- a preset name, not a raw scale factor, so it's
|
||||
# validated/enumerable the same way `theme` already is rather than
|
||||
# accepting an arbitrary float.
|
||||
text_scale: Mapped[str | None] = mapped_column(String(20))
|
||||
# #71: independent of text_scale above -- scales emoji rendered in
|
||||
# message text specifically, not the whole UI (see
|
||||
# frontend/src/components/MessageContent.tsx's --emoji-scale, scoped
|
||||
# to message content only so it can't also inflate the emoji picker's
|
||||
# grid or reaction pills).
|
||||
emoji_scale: Mapped[str | None] = mapped_column(String(20))
|
||||
# Only meaningful when theme == "custom" -- which of this user's saved
|
||||
# CustomTheme rows (app/models/custom_theme.py) is currently active.
|
||||
# Cleared explicitly (not via a DB-level ON DELETE) whenever that theme
|
||||
|
||||
@@ -100,6 +100,10 @@ async def update_profile(
|
||||
current_user.display_name = display_name or None
|
||||
if "theme" in updates:
|
||||
current_user.theme = updates["theme"]
|
||||
if "text_scale" in updates:
|
||||
current_user.text_scale = updates["text_scale"]
|
||||
if "emoji_scale" in updates:
|
||||
current_user.emoji_scale = updates["emoji_scale"]
|
||||
if "appear_offline" in updates:
|
||||
current_user.appear_offline = updates["appear_offline"]
|
||||
await db.commit()
|
||||
|
||||
@@ -23,6 +23,8 @@ class UserRead(BaseModel):
|
||||
is_site_admin: bool
|
||||
display_name: str | None
|
||||
theme: str | None
|
||||
text_scale: str | None
|
||||
emoji_scale: str | None
|
||||
# Resolved, not just an id -- the frontend needs the actual palette to
|
||||
# paint on load without a second round trip (see lib/theme.ts).
|
||||
active_custom_theme: CustomThemeRead | None
|
||||
@@ -57,6 +59,10 @@ class ProfileUpdate(BaseModel):
|
||||
# ownership check; that's POST /api/custom-themes/{id}/activate, not a
|
||||
# bare theme name with nothing to point it at.
|
||||
theme: Literal["dark", "light", "midnight", "sunset"] | None = Field(default=None)
|
||||
# #71: kept in sync with frontend/src/lib/theme.ts's TEXT_SCALE_PERCENT map.
|
||||
text_scale: Literal["small", "normal", "large", "xlarge"] | None = Field(default=None)
|
||||
# #71: kept in sync with MessageContent.tsx's EMOJI_SCALE_MULTIPLIER map.
|
||||
emoji_scale: Literal["small", "normal", "large", "xlarge"] | None = Field(default=None)
|
||||
appear_offline: bool | None = Field(default=None)
|
||||
|
||||
|
||||
|
||||
@@ -102,6 +102,62 @@ async def test_theme_custom_rejected_on_generic_profile_update(client, db_sessio
|
||||
assert resp.status_code == 422
|
||||
|
||||
|
||||
async def test_update_text_scale_persists(client, db_session):
|
||||
await register_and_login(client, db_session, username=_unique("alice"))
|
||||
|
||||
resp = await client.patch("/api/auth/me", json={"text_scale": "large"})
|
||||
assert resp.status_code == 200, resp.text
|
||||
assert resp.json()["text_scale"] == "large"
|
||||
|
||||
me = await client.get("/api/auth/me")
|
||||
assert me.json()["text_scale"] == "large"
|
||||
|
||||
|
||||
async def test_invalid_text_scale_rejected(client, db_session):
|
||||
await register_and_login(client, db_session, username=_unique("alice"))
|
||||
|
||||
resp = await client.patch("/api/auth/me", json={"text_scale": "huge"})
|
||||
assert resp.status_code == 422
|
||||
|
||||
|
||||
async def test_updating_text_scale_does_not_clobber_theme(client, db_session):
|
||||
await register_and_login(client, db_session, username=_unique("alice"))
|
||||
await client.patch("/api/auth/me", json={"theme": "sunset"})
|
||||
|
||||
resp = await client.patch("/api/auth/me", json={"text_scale": "xlarge"})
|
||||
assert resp.status_code == 200
|
||||
assert resp.json()["theme"] == "sunset"
|
||||
assert resp.json()["text_scale"] == "xlarge"
|
||||
|
||||
|
||||
async def test_update_emoji_scale_persists(client, db_session):
|
||||
await register_and_login(client, db_session, username=_unique("alice"))
|
||||
|
||||
resp = await client.patch("/api/auth/me", json={"emoji_scale": "xlarge"})
|
||||
assert resp.status_code == 200, resp.text
|
||||
assert resp.json()["emoji_scale"] == "xlarge"
|
||||
|
||||
me = await client.get("/api/auth/me")
|
||||
assert me.json()["emoji_scale"] == "xlarge"
|
||||
|
||||
|
||||
async def test_invalid_emoji_scale_rejected(client, db_session):
|
||||
await register_and_login(client, db_session, username=_unique("alice"))
|
||||
|
||||
resp = await client.patch("/api/auth/me", json={"emoji_scale": "huge"})
|
||||
assert resp.status_code == 422
|
||||
|
||||
|
||||
async def test_updating_emoji_scale_does_not_clobber_text_scale(client, db_session):
|
||||
await register_and_login(client, db_session, username=_unique("alice"))
|
||||
await client.patch("/api/auth/me", json={"text_scale": "large"})
|
||||
|
||||
resp = await client.patch("/api/auth/me", json={"emoji_scale": "small"})
|
||||
assert resp.status_code == 200
|
||||
assert resp.json()["text_scale"] == "large"
|
||||
assert resp.json()["emoji_scale"] == "small"
|
||||
|
||||
|
||||
async def test_avatar_upload_succeeds_and_persists(client, db_session):
|
||||
await register_and_login(client, db_session, username=_unique("alice"))
|
||||
|
||||
|
||||
Reference in New Issue
Block a user