Phase 7: Bot/extension system

Bot accounts (User rows with is_bot=True), scoped API tokens (read:messages,
write:messages, manage:rooms) authenticated via Authorization: Bearer on both
REST and the WS handshake, live bot WebSocket access on the same /ws/chat
endpoint humans use, message editing (WS "edit" envelope -> message_update
broadcast, fans out cross-instance for free via the existing broadcaster),
incoming webhooks (room-scoped, no auth beyond the URL token), and outgoing
webhooks/event subscriptions (HMAC-SHA256 signed, backgrounded delivery,
creation-time SSRF validation against private/loopback/link-local targets).

Token auth is additive, not a parallel system: a bearer-token-authenticated
bot goes through the exact same room-membership/role checks a session-
authenticated human does everywhere; only read:messages/write:messages are
separately scope-gated (the two message endpoints). manage:rooms scope
enforcement, full per-delivery SSRF re-validation, and bot API rate limiting
were explicitly scoped out (confirmed with the repo owner) as disproportionate
to this phase -- documented as known gaps in backend/README.md rather than
silently skipped.

Admin portal gains a Bots tab (create bots, issue/revoke scoped tokens,
cross-room webhook visibility); RoomInfoPanel gains room-scoped webhook/
subscription management, mirroring how invites already work there. The chat
UI also gets a minimal "edit your own message" affordance -- not asked for
by the issue, but the only practical way to exercise the edit pipeline by
hand instead of only via a scripted bot client.

Along the way: fixed a real bug caught while writing the incoming-webhook
test -- offline-push notification relied on the sender being "connected" to
exclude themselves, true for WS-originated messages but not for the new
webhook path, which has no WS connection for the attributed sender at all.
Now explicitly excluded. Also discovered the REST-only test fixture never
triggered ASGI lifespan, so app.state.broadcaster/presence didn't exist for
it; moved their construction out of the lifespan into create_app() itself
(Redis client construction is synchronous/lazy) so both the WS and
REST-only paths always have them.

New tests/test_bots.py, test_message_edit.py, test_webhooks.py (full suite
now 78/78, stable across repeated runs) plus a scripted end-to-end smoke
test (bot WS join/post/edit, incoming webhook, SSRF rejection, outgoing
delivery) and a full browser walkthrough of the new admin/room UI.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
2026-08-14 08:12:41 -06:00
co-authored by Claude Sonnet 5
parent 4aa8ef89c5
commit 0ab23c44a7
41 changed files with 2607 additions and 137 deletions
+15 -1
View File
@@ -1,5 +1,11 @@
import { apiFetch } from './client'
import type { AdminRoom, AdminUser, AuditLogEntry } from '../types'
import type {
AdminRoom,
AdminUser,
AuditLogEntry,
EventSubscriptionAdmin,
WebhookIncomingAdmin,
} from '../types'
export function listAdminUsers(): Promise<AdminUser[]> {
return apiFetch<AdminUser[]>('/api/admin/users')
@@ -50,3 +56,11 @@ export function transferOwnershipAdmin(roomId: string, newOwnerId: string): Prom
export function listAuditLog(limit = 50, offset = 0): Promise<AuditLogEntry[]> {
return apiFetch<AuditLogEntry[]>(`/api/admin/audit-log?limit=${limit}&offset=${offset}`)
}
export function listAllIncomingWebhooks(): Promise<WebhookIncomingAdmin[]> {
return apiFetch<WebhookIncomingAdmin[]>('/api/admin/webhooks/incoming')
}
export function listAllEventSubscriptions(): Promise<EventSubscriptionAdmin[]> {
return apiFetch<EventSubscriptionAdmin[]>('/api/admin/event-subscriptions')
}
+28
View File
@@ -0,0 +1,28 @@
import { apiFetch } from './client'
import type { ApiScope, ApiToken, ApiTokenCreated, Bot } from '../types'
export function createBot(username: string): Promise<Bot> {
return apiFetch<Bot>('/api/admin/bots', {
method: 'POST',
body: JSON.stringify({ username }),
})
}
export function listBots(): Promise<Bot[]> {
return apiFetch<Bot[]>('/api/admin/bots')
}
export function createApiToken(botId: string, scopes: ApiScope[]): Promise<ApiTokenCreated> {
return apiFetch<ApiTokenCreated>(`/api/admin/bots/${botId}/tokens`, {
method: 'POST',
body: JSON.stringify({ scopes }),
})
}
export function listApiTokens(botId: string): Promise<ApiToken[]> {
return apiFetch<ApiToken[]>(`/api/admin/bots/${botId}/tokens`)
}
export function revokeApiToken(tokenId: string): Promise<void> {
return apiFetch<void>(`/api/admin/bots/tokens/${tokenId}`, { method: 'DELETE' })
}
+48
View File
@@ -0,0 +1,48 @@
import { apiFetch } from './client'
import type {
EventSubscription,
EventSubscriptionCreated,
EventType,
WebhookIncoming,
} from '../types'
export function createIncomingWebhook(
roomId: string,
description?: string,
): Promise<WebhookIncoming> {
return apiFetch<WebhookIncoming>(`/api/rooms/${roomId}/webhooks/incoming`, {
method: 'POST',
body: JSON.stringify({ description: description || null }),
})
}
export function listIncomingWebhooks(roomId: string): Promise<WebhookIncoming[]> {
return apiFetch<WebhookIncoming[]>(`/api/rooms/${roomId}/webhooks/incoming`)
}
export function revokeIncomingWebhook(roomId: string, webhookId: string): Promise<void> {
return apiFetch<void>(`/api/rooms/${roomId}/webhooks/incoming/${webhookId}`, {
method: 'DELETE',
})
}
export function createEventSubscription(
roomId: string,
eventTypes: EventType[],
targetUrl: string,
): Promise<EventSubscriptionCreated> {
return apiFetch<EventSubscriptionCreated>(`/api/rooms/${roomId}/event-subscriptions`, {
method: 'POST',
body: JSON.stringify({ event_types: eventTypes, target_url: targetUrl }),
})
}
export function listEventSubscriptions(roomId: string): Promise<EventSubscription[]> {
return apiFetch<EventSubscription[]>(`/api/rooms/${roomId}/event-subscriptions`)
}
export function revokeEventSubscription(roomId: string, subscriptionId: string): Promise<void> {
return apiFetch<void>(`/api/rooms/${roomId}/event-subscriptions/${subscriptionId}`, {
method: 'DELETE',
})
}