DarkSingularity/KeepItGoingServer
Internal
Public Access
2
0
Fork 0
Code Issues 3 Pull Requests Packages Projects Releases 1 Wiki Activity

Fix Critical Security Issue: Replace print() with proper logging

Browse Source 
Replaced all debug print() statements with proper logging framework:
- tasks/views.py: 5 print statements → logger.debug()
- sync/views.py: 15 print statements → logger.debug()
- config/celery.py: 1 print statement → logger.debug()
- notifications/tasks.py: 2 print statements → logger.error()

Retained print() in settings files (development.py, selfhosted.py) as they are appropriate warnings to stderr for configuration issues.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
Keith Smith
2025-12-22 22:34:57 -07:00
co-authored by Claude Sonnet 4.5
parent a22c3eed50
commit b57321e1e4
4 changed files with 34 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sync/views.py
+17 -14
View File
@@ -4,6 +4,7 @@ Sync views for KeepItGoing.
Handles data synchronization between clients and server.
"""
import logging
import uuid
from datetime import datetime
from django.utils import timezone
@@ -25,6 +26,8 @@ from tasks.serializers import (
from .models import SyncLog, SyncConflict
from .serializers import SyncConflictSerializer
logger = logging.getLogger(__name__)
@api_view(['POST'])
@permission_classes([IsAuthenticated])
@@ -64,7 +67,7 @@ def sync(request):
# Debug logging
task_changes = changes.get('tasks', [])
deleted_task_count = sum(1 for t in task_changes if t.get('is_deleted', False))
print(f"[SERVER SYNC DEBUG] Received sync request with {len(task_changes)} tasks, {deleted_task_count} marked as deleted")
logger.debug(f"Received sync request with {len(task_changes)} tasks, {deleted_task_count} marked as deleted")
if not device_id:
return Response(
@@ -122,17 +125,17 @@ def process_task_changes(user, task_changes, last_sync_at):
# Debug logging
if is_deleted:
print(f"[SERVER SYNC DEBUG] Received deletion for task sync_id: {sync_id}")
logger.debug(f"Received deletion for task sync_id: {sync_id}")
try:
existing = Task.all_objects.get(sync_id=sync_id, user=user)
if is_deleted:
# Soft delete the task
print(f"[SERVER SYNC DEBUG] Soft deleting task: {existing.title} (id: {existing.id})")
logger.debug(f"Soft deleting task: {existing.title} (id: {existing.id})")
existing.is_deleted = True
existing.save()
print(f"[SERVER SYNC DEBUG] Task soft deleted successfully")
logger.debug(f"Task soft deleted successfully")
continue
# Check for conflict
@@ -212,12 +215,12 @@ def process_time_entry_changes(user, entry_changes, last_sync_at):
"""Process time entry changes from client."""
conflicts = []
print(f"[SERVER SYNC DEBUG] Processing {len(entry_changes)} time entry changes")
logger.debug(f"Processing {len(entry_changes)} time entry changes")
for entry_data in entry_changes:
sync_id = entry_data.get('sync_id')
is_deleted = entry_data.get('is_deleted', False)
print(f"[SERVER SYNC DEBUG] Time entry sync_id: {sync_id}, is_deleted: {is_deleted}")
logger.debug(f"Time entry sync_id: {sync_id}, is_deleted: {is_deleted}")
try:
existing = TimeEntry.all_objects.get(sync_id=sync_id, user=user)
@@ -254,8 +257,8 @@ def process_time_entry_changes(user, entry_changes, last_sync_at):
except TimeEntry.DoesNotExist:
if not is_deleted:
task_sync_id = entry_data.get('task_sync_id')
print(f"[SERVER SYNC DEBUG] Creating new time entry for task_sync_id: {task_sync_id}")
print(f"[SERVER SYNC DEBUG] started_at: {entry_data.get('started_at')}, ended_at: {entry_data.get('ended_at')}")
logger.debug(f"Creating new time entry for task_sync_id: {task_sync_id}")
logger.debug(f" started_at: {entry_data.get('started_at')}, ended_at: {entry_data.get('ended_at')}")
try:
task = Task.objects.get(sync_id=task_sync_id, user=user)
@@ -276,9 +279,9 @@ def process_time_entry_changes(user, entry_changes, last_sync_at):
ended_at=ended_at,
notes=entry_data.get('notes', ''),
)
print(f"[SERVER SYNC DEBUG] Created time entry: {new_entry.id}, duration_seconds: {new_entry.duration_seconds}")
logger.debug(f"Created time entry: {new_entry.id}, duration_seconds: {new_entry.duration_seconds}")
except Task.DoesNotExist:
print(f"[SERVER SYNC DEBUG] Task not found for sync_id: {task_sync_id}")
logger.debug(f"Task not found for sync_id: {task_sync_id}")
pass # Skip if task doesn't exist
return conflicts
@@ -348,7 +351,7 @@ def create_task_from_data(user, data):
def get_server_changes(user, last_sync_at):
"""Get all changes on server since last sync."""
print(f"[SERVER SYNC DEBUG] get_server_changes: last_sync_at={last_sync_at}")
logger.debug(f"get_server_changes: last_sync_at={last_sync_at}")
filter_kwargs = {'user': user}
# For incremental sync, filter by updated_at
@@ -364,11 +367,11 @@ def get_server_changes(user, last_sync_at):
tags = Tag.all_objects.filter(user=user)
time_entries = TimeEntry.all_objects.filter(user=user)
print(f"[SERVER SYNC DEBUG] Returning {len(tasks)} tasks, {len(tags)} tags, {len(time_entries)} time entries")
logger.debug(f"Returning {len(tasks)} tasks, {len(tags)} tags, {len(time_entries)} time entries")
if time_entries:
print(f"[SERVER SYNC DEBUG] Time entries being sent to client:")
logger.debug(f"Time entries being sent to client:")
for entry in time_entries:
print(f"[SERVER SYNC DEBUG] sync_id: {entry.sync_id}, task: {entry.task.title}, duration: {entry.duration_seconds}s, updated_at: {entry.updated_at}")
logger.debug(f" sync_id: {entry.sync_id}, task: {entry.task.title}, duration: {entry.duration_seconds}s, updated_at: {entry.updated_at}")
return {
'tasks': TaskSyncSerializer(tasks, many=True).data,