Internal
Public Access
Add email verification, admin approval, and user profile enhancements
Implement comprehensive email verification and admin approval system for user registration. Users must verify their email before logging in, and admins must approve new users before they can access the system. Major features: - Email verification with UUID tokens (24hr expiry, one-time use) - Admin approval workflow via Django admin interface - Custom authentication backend enforcing verification and approval - Password change functionality for authenticated users - Enhanced profile page with proper styling and theme support - Collect first name, last name, and timezone during registration - Profile link added to header navigation Email notifications: - Verification email sent after registration - Admin notification when users need approval - Approval notification sent to users Security features: - Cryptographically secure UUID tokens - Token expiration and one-time use enforcement - Email enumeration protection - Custom JWT token validation for API access - Existing users auto-approved via data migration Templates added: - Email templates (verification, approval, admin notification) - Web templates (password change, verification pages) - Enhanced profile page with dark/light mode support 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
Keith Smith
co-authored by
Claude Sonnet 4.5
Claude Sonnet 4.5
parent
87afc4e80c
commit
21d9d01885
+336
-14
@@ -4,11 +4,15 @@ User views for KeepItGoing.
|
||||
|
||||
from django.contrib.auth import get_user_model, login, logout
|
||||
from django.shortcuts import render, redirect
|
||||
from django.utils import timezone
|
||||
from django.views import View
|
||||
from rest_framework import generics, permissions, status
|
||||
from rest_framework.response import Response
|
||||
from rest_framework.views import APIView
|
||||
from rest_framework.exceptions import AuthenticationFailed
|
||||
from rest_framework_simplejwt.tokens import RefreshToken
|
||||
from rest_framework_simplejwt.views import TokenObtainPairView as BaseTokenObtainPairView
|
||||
from rest_framework_simplejwt.serializers import TokenObtainPairSerializer
|
||||
|
||||
from .serializers import (
|
||||
UserSerializer,
|
||||
@@ -16,7 +20,7 @@ from .serializers import (
|
||||
ChangePasswordSerializer,
|
||||
DeviceTokenSerializer,
|
||||
)
|
||||
from .models import DeviceToken
|
||||
from .models import DeviceToken, EmailVerificationToken
|
||||
|
||||
User = get_user_model()
|
||||
|
||||
@@ -37,15 +41,16 @@ class RegisterAPIView(generics.CreateAPIView):
|
||||
serializer.is_valid(raise_exception=True)
|
||||
user = serializer.save()
|
||||
|
||||
# Generate tokens
|
||||
refresh = RefreshToken.for_user(user)
|
||||
# Send verification email
|
||||
from .utils import send_verification_email
|
||||
send_verification_email(user, request)
|
||||
|
||||
# DO NOT generate tokens - user must verify email first
|
||||
return Response({
|
||||
'user': UserSerializer(user).data,
|
||||
'tokens': {
|
||||
'refresh': str(refresh),
|
||||
'access': str(refresh.access_token),
|
||||
}
|
||||
'message': 'Registration successful! Please check your email to verify your account.',
|
||||
'email': user.email,
|
||||
'email_verified': False,
|
||||
'is_approved': False,
|
||||
}, status=status.HTTP_201_CREATED)
|
||||
|
||||
|
||||
@@ -97,6 +102,131 @@ class DeviceTokenDeleteAPIView(generics.DestroyAPIView):
|
||||
return DeviceToken.objects.filter(user=self.request.user)
|
||||
|
||||
|
||||
class VerifyEmailAPIView(APIView):
|
||||
"""API endpoint for email verification."""
|
||||
|
||||
permission_classes = [permissions.AllowAny]
|
||||
|
||||
def post(self, request):
|
||||
token_value = request.data.get('token')
|
||||
|
||||
if not token_value:
|
||||
return Response(
|
||||
{'error': 'Token is required.'},
|
||||
status=status.HTTP_400_BAD_REQUEST
|
||||
)
|
||||
|
||||
try:
|
||||
token = EmailVerificationToken.objects.get(token=token_value)
|
||||
except EmailVerificationToken.DoesNotExist:
|
||||
return Response(
|
||||
{'error': 'Invalid verification token.'},
|
||||
status=status.HTTP_400_BAD_REQUEST
|
||||
)
|
||||
|
||||
if token.is_used:
|
||||
return Response(
|
||||
{'error': 'This verification link has already been used.'},
|
||||
status=status.HTTP_400_BAD_REQUEST
|
||||
)
|
||||
|
||||
if token.is_expired():
|
||||
return Response(
|
||||
{'error': 'This verification link has expired. Please request a new one.'},
|
||||
status=status.HTTP_400_BAD_REQUEST
|
||||
)
|
||||
|
||||
# Mark email as verified
|
||||
user = token.user
|
||||
user.email_verified = True
|
||||
user.email_verified_at = timezone.now()
|
||||
user.save(update_fields=['email_verified', 'email_verified_at'])
|
||||
|
||||
# Mark token as used
|
||||
token.is_used = True
|
||||
token.used_at = timezone.now()
|
||||
token.save(update_fields=['is_used', 'used_at'])
|
||||
|
||||
# Notify admins if not yet approved
|
||||
if not user.is_approved:
|
||||
from .utils import notify_admins_new_user
|
||||
notify_admins_new_user(user)
|
||||
|
||||
return Response({
|
||||
'message': 'Email verified successfully.',
|
||||
'email_verified': True,
|
||||
'is_approved': user.is_approved,
|
||||
})
|
||||
|
||||
|
||||
class ResendVerificationEmailAPIView(APIView):
|
||||
"""API endpoint to resend verification email."""
|
||||
|
||||
permission_classes = [permissions.AllowAny]
|
||||
|
||||
def post(self, request):
|
||||
email = request.data.get('email')
|
||||
|
||||
if not email:
|
||||
return Response(
|
||||
{'error': 'Email is required.'},
|
||||
status=status.HTTP_400_BAD_REQUEST
|
||||
)
|
||||
|
||||
try:
|
||||
user = User.objects.get(email=email)
|
||||
except User.DoesNotExist:
|
||||
# Don't reveal if email exists
|
||||
return Response({
|
||||
'message': 'If that email is registered, a verification link has been sent.'
|
||||
})
|
||||
|
||||
if user.email_verified:
|
||||
return Response(
|
||||
{'error': 'Email is already verified.'},
|
||||
status=status.HTTP_400_BAD_REQUEST
|
||||
)
|
||||
|
||||
from .utils import send_verification_email
|
||||
send_verification_email(user, request)
|
||||
|
||||
return Response({
|
||||
'message': 'Verification email sent.'
|
||||
})
|
||||
|
||||
|
||||
class CustomTokenObtainPairSerializer(TokenObtainPairSerializer):
|
||||
"""Custom JWT token serializer that checks verification and approval."""
|
||||
|
||||
def validate(self, attrs):
|
||||
# Authenticate user
|
||||
data = super().validate(attrs)
|
||||
|
||||
# Check email verification
|
||||
if not self.user.email_verified:
|
||||
raise AuthenticationFailed({
|
||||
'error': 'email_not_verified',
|
||||
'message': 'Please verify your email address before logging in.',
|
||||
'email': self.user.email,
|
||||
})
|
||||
|
||||
# Check admin approval
|
||||
if not self.user.is_approved:
|
||||
raise AuthenticationFailed({
|
||||
'error': 'not_approved',
|
||||
'message': 'Your account is pending admin approval.',
|
||||
'email': self.user.email,
|
||||
})
|
||||
|
||||
return data
|
||||
|
||||
|
||||
class TokenObtainPairView(BaseTokenObtainPairView):
|
||||
"""Custom JWT token view using our custom serializer."""
|
||||
|
||||
serializer_class = CustomTokenObtainPairSerializer
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Web Views (Django Templates)
|
||||
# =============================================================================
|
||||
@@ -107,7 +237,27 @@ class LoginView(View):
|
||||
def get(self, request):
|
||||
if request.user.is_authenticated:
|
||||
return redirect('dashboard')
|
||||
return render(request, 'users/login.html')
|
||||
|
||||
# Check for special error conditions from authentication backend
|
||||
error = None
|
||||
email = None
|
||||
can_resend = False
|
||||
|
||||
if 'login_error' in request.session:
|
||||
error_type = request.session.pop('login_error')
|
||||
email = request.session.pop('login_email', None)
|
||||
|
||||
if error_type == 'email_not_verified':
|
||||
error = 'Please verify your email address before logging in.'
|
||||
can_resend = True
|
||||
elif error_type == 'not_approved':
|
||||
error = 'Your account is pending admin approval.'
|
||||
|
||||
return render(request, 'users/login.html', {
|
||||
'error': error,
|
||||
'email': email,
|
||||
'can_resend': can_resend,
|
||||
})
|
||||
|
||||
def post(self, request):
|
||||
from django.contrib.auth import authenticate
|
||||
@@ -122,8 +272,26 @@ class LoginView(View):
|
||||
next_url = request.GET.get('next', 'dashboard')
|
||||
return redirect(next_url)
|
||||
|
||||
# Check if error info was set by authentication backend
|
||||
error = 'Invalid email or password.'
|
||||
can_resend = False
|
||||
|
||||
if 'login_error' in request.session:
|
||||
error_type = request.session.pop('login_error')
|
||||
email_from_session = request.session.pop('login_email', None)
|
||||
|
||||
if error_type == 'email_not_verified':
|
||||
error = 'Please verify your email address before logging in.'
|
||||
can_resend = True
|
||||
email = email_from_session
|
||||
elif error_type == 'not_approved':
|
||||
error = 'Your account is pending admin approval.'
|
||||
email = email_from_session
|
||||
|
||||
return render(request, 'users/login.html', {
|
||||
'error': 'Invalid email or password.'
|
||||
'error': error,
|
||||
'email': email,
|
||||
'can_resend': can_resend,
|
||||
})
|
||||
|
||||
|
||||
@@ -152,6 +320,9 @@ class RegisterView(View):
|
||||
username = request.POST.get('username')
|
||||
password = request.POST.get('password')
|
||||
password_confirm = request.POST.get('password_confirm')
|
||||
first_name = request.POST.get('first_name', '')
|
||||
last_name = request.POST.get('last_name', '')
|
||||
timezone = request.POST.get('timezone', 'UTC')
|
||||
|
||||
errors = {}
|
||||
|
||||
@@ -165,15 +336,32 @@ class RegisterView(View):
|
||||
errors['username'] = 'Username already taken.'
|
||||
|
||||
if errors:
|
||||
return render(request, 'users/register.html', {'errors': errors})
|
||||
return render(request, 'users/register.html', {
|
||||
'errors': errors,
|
||||
'email': email,
|
||||
'username': username,
|
||||
'first_name': first_name,
|
||||
'last_name': last_name,
|
||||
'timezone': timezone,
|
||||
})
|
||||
|
||||
user = User.objects.create_user(
|
||||
email=email,
|
||||
username=username,
|
||||
password=password
|
||||
password=password,
|
||||
first_name=first_name,
|
||||
last_name=last_name,
|
||||
timezone=timezone
|
||||
)
|
||||
login(request, user)
|
||||
return redirect('dashboard')
|
||||
|
||||
# Send verification email
|
||||
from .utils import send_verification_email
|
||||
send_verification_email(user, request)
|
||||
|
||||
# DO NOT auto-login
|
||||
return render(request, 'users/register_success.html', {
|
||||
'email': user.email
|
||||
})
|
||||
|
||||
|
||||
class ProfileView(View):
|
||||
@@ -200,3 +388,137 @@ class ProfileView(View):
|
||||
return render(request, 'users/profile.html', {
|
||||
'success': 'Profile updated successfully.'
|
||||
})
|
||||
|
||||
|
||||
class VerifyEmailWebView(View):
|
||||
"""Web view for email verification via link."""
|
||||
|
||||
def get(self, request, token):
|
||||
try:
|
||||
token_obj = EmailVerificationToken.objects.get(token=token)
|
||||
except EmailVerificationToken.DoesNotExist:
|
||||
return render(request, 'users/verify_email.html', {
|
||||
'success': False,
|
||||
'error': 'Invalid verification link.'
|
||||
})
|
||||
|
||||
if token_obj.is_used:
|
||||
return render(request, 'users/verify_email.html', {
|
||||
'success': False,
|
||||
'error': 'This verification link has already been used.'
|
||||
})
|
||||
|
||||
if token_obj.is_expired():
|
||||
return render(request, 'users/verify_email.html', {
|
||||
'success': False,
|
||||
'error': 'This verification link has expired.',
|
||||
'can_resend': True,
|
||||
'email': token_obj.user.email,
|
||||
})
|
||||
|
||||
# Verify email
|
||||
user = token_obj.user
|
||||
user.email_verified = True
|
||||
user.email_verified_at = timezone.now()
|
||||
user.save(update_fields=['email_verified', 'email_verified_at'])
|
||||
|
||||
token_obj.is_used = True
|
||||
token_obj.used_at = timezone.now()
|
||||
token_obj.save(update_fields=['is_used', 'used_at'])
|
||||
|
||||
# Notify admins
|
||||
if not user.is_approved:
|
||||
from .utils import notify_admins_new_user
|
||||
notify_admins_new_user(user)
|
||||
|
||||
return render(request, 'users/verify_email.html', {
|
||||
'success': True,
|
||||
'is_approved': user.is_approved,
|
||||
})
|
||||
|
||||
|
||||
class ResendVerificationWebView(View):
|
||||
"""Web view for resending verification email."""
|
||||
|
||||
def get(self, request):
|
||||
return render(request, 'users/resend_verification.html')
|
||||
|
||||
def post(self, request):
|
||||
email = request.POST.get('email')
|
||||
|
||||
if not email:
|
||||
return render(request, 'users/resend_verification.html', {
|
||||
'error': 'Email is required.'
|
||||
})
|
||||
|
||||
try:
|
||||
user = User.objects.get(email=email)
|
||||
except User.DoesNotExist:
|
||||
# Don't reveal if email exists
|
||||
return render(request, 'users/resend_verification.html', {
|
||||
'success': True,
|
||||
'message': 'If that email is registered, a verification link has been sent.'
|
||||
})
|
||||
|
||||
if user.email_verified:
|
||||
return render(request, 'users/resend_verification.html', {
|
||||
'error': 'Email is already verified.'
|
||||
})
|
||||
|
||||
from .utils import send_verification_email
|
||||
send_verification_email(user, request)
|
||||
|
||||
return render(request, 'users/resend_verification.html', {
|
||||
'success': True,
|
||||
'message': 'Verification email sent. Please check your inbox.'
|
||||
})
|
||||
|
||||
|
||||
class ChangePasswordWebView(View):
|
||||
"""Web view for changing password."""
|
||||
|
||||
def get(self, request):
|
||||
if not request.user.is_authenticated:
|
||||
return redirect('login')
|
||||
return render(request, 'users/change_password.html')
|
||||
|
||||
def post(self, request):
|
||||
if not request.user.is_authenticated:
|
||||
return redirect('login')
|
||||
|
||||
old_password = request.POST.get('old_password')
|
||||
new_password = request.POST.get('new_password')
|
||||
confirm_password = request.POST.get('confirm_password')
|
||||
|
||||
errors = {}
|
||||
|
||||
# Validate old password
|
||||
if not request.user.check_password(old_password):
|
||||
errors['old_password'] = 'Current password is incorrect.'
|
||||
|
||||
# Validate new passwords match
|
||||
if new_password != confirm_password:
|
||||
errors['confirm_password'] = 'New passwords do not match.'
|
||||
|
||||
# Validate password length
|
||||
if len(new_password) < 8:
|
||||
errors['new_password'] = 'Password must be at least 8 characters long.'
|
||||
|
||||
# Validate new password is different from old
|
||||
if old_password == new_password:
|
||||
errors['new_password'] = 'New password must be different from current password.'
|
||||
|
||||
if errors:
|
||||
return render(request, 'users/change_password.html', {'errors': errors})
|
||||
|
||||
# Change the password
|
||||
request.user.set_password(new_password)
|
||||
request.user.save()
|
||||
|
||||
# Re-login the user so their session isn't invalidated
|
||||
from django.contrib.auth import update_session_auth_hash
|
||||
update_session_auth_hash(request, request.user)
|
||||
|
||||
return render(request, 'users/change_password.html', {
|
||||
'success': 'Password changed successfully!'
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user