Private
Public Access
fetch_feed had no time limit and no handling for anything beyond the network/parse errors fetch_and_ingest already catches internally — an unexpected exception (a parser/sanitizer bug, a DB error) crashed the task with no error recorded on the Feed, the claim left held for the full CLAIM_STALE_MINUTES, and no visibility beyond a bare traceback. fetch_feed now catches that, records it the same way a handled failure would be (reusing fetcher.record_fetch_error, promoted from a private helper), clears the claim, and re-raises so Celery still marks the task FAILED. soft_time_limit/time_limit bound a single fetch that somehow outruns FETCH_TIMEOUT_SECONDS + ssrf_guard's response cap during parsing/ingestion. Also: a worker process killed mid-task (OOM, deploy restart, crash) previously lost that task silently — Celery's default is to ack a message the moment a worker *starts* it. CELERY_TASK_ACKS_LATE + CELERY_TASK_REJECT_ON_WORKER_LOST (config/settings/base.py) make the message redeliverable instead, and CELERY_WORKER_PREFETCH_MULTIPLIER=1 keeps a worker from grabbing a batch of tasks it could lose all at once. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
140 lines
4.7 KiB
Python
140 lines
4.7 KiB
Python
"""
|
|
Base Django settings for Evection, shared by all environments.
|
|
|
|
Environment-specific overrides live in dev.py / prod.py / test.py.
|
|
"""
|
|
|
|
from pathlib import Path
|
|
|
|
import environ
|
|
|
|
BASE_DIR = Path(__file__).resolve().parent.parent.parent
|
|
|
|
env = environ.Env()
|
|
env_file = BASE_DIR / ".env"
|
|
if env_file.exists():
|
|
environ.Env.read_env(str(env_file))
|
|
|
|
SECRET_KEY = env.str("SECRET_KEY", default="django-insecure-change-me-in-production")
|
|
DEBUG = env.bool("DEBUG", default=False)
|
|
ALLOWED_HOSTS = env.list("ALLOWED_HOSTS", default=["localhost", "127.0.0.1"])
|
|
|
|
INSTALLED_APPS = [
|
|
"django.contrib.admin",
|
|
"django.contrib.auth",
|
|
"django.contrib.contenttypes",
|
|
"django.contrib.sessions",
|
|
"django.contrib.messages",
|
|
"django.contrib.staticfiles",
|
|
# third-party
|
|
"django_htmx",
|
|
# Evection apps
|
|
"apps.core",
|
|
"apps.accounts",
|
|
"apps.feeds",
|
|
"apps.articles",
|
|
"apps.rules",
|
|
"apps.search",
|
|
"apps.reader",
|
|
"apps.pwa",
|
|
]
|
|
|
|
MIDDLEWARE = [
|
|
"django.middleware.security.SecurityMiddleware",
|
|
"django.contrib.sessions.middleware.SessionMiddleware",
|
|
"django.middleware.common.CommonMiddleware",
|
|
"django.middleware.csrf.CsrfViewMiddleware",
|
|
"django.contrib.auth.middleware.AuthenticationMiddleware",
|
|
"django.contrib.messages.middleware.MessageMiddleware",
|
|
"django.middleware.clickjacking.XFrameOptionsMiddleware",
|
|
"django_htmx.middleware.HtmxMiddleware",
|
|
"apps.accounts.middleware.SetupWizardMiddleware",
|
|
]
|
|
|
|
ROOT_URLCONF = "config.urls"
|
|
|
|
TEMPLATES = [
|
|
{
|
|
"BACKEND": "django.template.backends.django.DjangoTemplates",
|
|
"DIRS": [BASE_DIR / "templates"],
|
|
"APP_DIRS": True,
|
|
"OPTIONS": {
|
|
"context_processors": [
|
|
"django.template.context_processors.request",
|
|
"django.contrib.auth.context_processors.auth",
|
|
"django.contrib.messages.context_processors.messages",
|
|
"apps.core.context_processors.sidebar",
|
|
],
|
|
},
|
|
},
|
|
]
|
|
|
|
WSGI_APPLICATION = "config.wsgi.application"
|
|
ASGI_APPLICATION = "config.asgi.application"
|
|
|
|
# Database — DATABASE_URL drives both SQLite and Postgres installs, e.g.:
|
|
# sqlite:///db.sqlite3
|
|
# postgres://user:pass@host:5432/dbname
|
|
DATABASES = {"default": env.db_url("DATABASE_URL", default=f"sqlite:///{BASE_DIR / 'db.sqlite3'}")}
|
|
|
|
AUTH_USER_MODEL = "accounts.User"
|
|
|
|
AUTH_PASSWORD_VALIDATORS = [
|
|
{"NAME": "django.contrib.auth.password_validation.UserAttributeSimilarityValidator"},
|
|
{"NAME": "django.contrib.auth.password_validation.MinimumLengthValidator"},
|
|
{"NAME": "django.contrib.auth.password_validation.CommonPasswordValidator"},
|
|
{"NAME": "django.contrib.auth.password_validation.NumericPasswordValidator"},
|
|
]
|
|
|
|
LOGIN_URL = "accounts:login"
|
|
LOGIN_REDIRECT_URL = "reader:stream"
|
|
LOGOUT_REDIRECT_URL = "accounts:login"
|
|
|
|
LANGUAGE_CODE = "en-us"
|
|
TIME_ZONE = "UTC"
|
|
USE_I18N = True
|
|
USE_TZ = True
|
|
|
|
STATIC_URL = "static/"
|
|
STATICFILES_DIRS = [BASE_DIR / "static"]
|
|
STATIC_ROOT = BASE_DIR / "staticfiles"
|
|
|
|
DEFAULT_AUTO_FIELD = "django.db.models.BigAutoField"
|
|
|
|
# Evection-specific settings
|
|
EVECTION_SIGNUP_ENABLED = env.bool("EVECTION_SIGNUP_ENABLED", default=False)
|
|
EVECTION_MIN_FETCH_INTERVAL_MINUTES = env.int("EVECTION_MIN_FETCH_INTERVAL_MINUTES", default=15)
|
|
EVECTION_PWA_CACHE_VERSION = env.str("EVECTION_PWA_CACHE_VERSION", default="v1")
|
|
|
|
# Redis-backed rather than Django's default per-process LocMemCache: login
|
|
# rate limiting (apps.accounts.views) must share counters across every
|
|
# gunicorn worker, not just whichever one happened to handle a given
|
|
# request. Redis is already a hard install requirement for Celery, so
|
|
# this adds no new infrastructure — just a distinct key prefix so cache
|
|
# keys can't collide with anything else sharing that Redis instance.
|
|
CACHES = {
|
|
"default": {
|
|
"BACKEND": "django.core.cache.backends.redis.RedisCache",
|
|
"LOCATION": env.str("REDIS_URL", default="redis://localhost:6379/0"),
|
|
"KEY_PREFIX": "evection-cache",
|
|
}
|
|
}
|
|
|
|
# Celery
|
|
CELERY_BROKER_URL = env.str("REDIS_URL", default="redis://localhost:6379/0")
|
|
CELERY_RESULT_BACKEND = None
|
|
CELERY_TASK_SERIALIZER = "json"
|
|
CELERY_ACCEPT_CONTENT = ["json"]
|
|
CELERY_TIMEZONE = TIME_ZONE
|
|
|
|
# Without these, a worker process killed mid-task (OOM, deploy restart,
|
|
# crash) silently loses that task: the default is to ack a message the
|
|
# moment a worker *starts* it, not when it finishes. acks_late + reject-
|
|
# on-worker-lost means the message is only consumed on completion (success
|
|
# or a handled failure) and is redelivered to another worker otherwise.
|
|
# prefetch_multiplier=1 keeps a worker from grabbing a batch of tasks it
|
|
# could similarly lose all at once.
|
|
CELERY_TASK_ACKS_LATE = True
|
|
CELERY_TASK_REJECT_ON_WORKER_LOST = True
|
|
CELERY_WORKER_PREFETCH_MULTIPLIER = 1
|