Files
Evection/apps/accounts/tests.py
T
ksmithandClaude Sonnet 5 1a8ae95db0 Fix logout 405 — Django's LogoutView only accepts POST
The sidebar's "Log out" was a plain <a href> GET link. Django 5's
LogoutView stopped accepting GET (CSRF hardening — a bare link or even an
<img> tag could otherwise log someone out), so clicking it 405'd instead
of logging out. Changed it to a POST form, matching every other
state-changing action in the sidebar/app (unsubscribe, delete tag, etc.).

Extended .sidebar-top-nav's styling to cover a <button> the same as an
<a>, so the form-submit button looks identical to the other nav items.

No existing test exercised logout at all — added one for the POST case
and one confirming GET now correctly 405s, then verified end-to-end
against the running dev server (login, POST /logout/, confirm the session
is gone).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-10-30 22:01:06 -06:00

124 lines
3.9 KiB
Python

import pytest
from django.urls import reverse
from .middleware import SetupWizardMiddleware
from .models import User
@pytest.fixture(autouse=True)
def _reset_setup_wizard_cache():
SetupWizardMiddleware._a_user_exists = False
yield
SetupWizardMiddleware._a_user_exists = False
@pytest.mark.django_db
def test_root_redirects_to_setup_when_no_users_exist(client):
response = client.get("/", follow=False)
assert response.status_code == 302
assert response.url == reverse("accounts:setup")
@pytest.mark.django_db
def test_pwa_routes_bypass_the_setup_redirect(client):
for url_name in ["pwa:manifest", "pwa:service_worker", "pwa:offline"]:
response = client.get(reverse(url_name))
assert response.status_code == 200, url_name
@pytest.mark.django_db
def test_setup_creates_admin_and_logs_in(client):
response = client.post(
reverse("accounts:setup"),
{
"username": "keith",
"email": "keith@example.com",
"password": "correct-horse-battery",
"password_confirm": "correct-horse-battery",
},
)
assert response.status_code == 302
assert response.url == reverse("reader:stream")
user = User.objects.get(username="keith")
assert user.is_staff
assert user.is_superuser
stream_response = client.get(reverse("reader:stream"))
assert stream_response.status_code == 200
@pytest.mark.django_db
def test_setup_is_unreachable_once_a_user_exists(client):
User.objects.create_user("existing", password="irrelevant")
response = client.get(reverse("accounts:setup"))
assert response.status_code == 302
assert response.url == reverse("accounts:login")
@pytest.mark.django_db
def test_setup_rejects_mismatched_passwords(client):
response = client.post(
reverse("accounts:setup"),
{
"username": "keith",
"email": "keith@example.com",
"password": "correct-horse-battery",
"password_confirm": "does-not-match",
},
)
assert response.status_code == 200
assert not User.objects.exists()
@pytest.mark.django_db
def test_logout_via_post_logs_the_user_out(client):
User.objects.create_user("keith", password="pw-keith-123")
client.login(username="keith", password="pw-keith-123")
response = client.post(reverse("accounts:logout"))
assert response.status_code == 302
stream_response = client.get(reverse("reader:stream"))
assert stream_response.status_code == 302
assert stream_response.url.startswith(reverse("accounts:login"))
@pytest.mark.django_db
def test_logout_rejects_get(client):
# Django's LogoutView only accepts POST (see templates/core/_sidebar.html,
# which submits it as a form rather than a plain link).
User.objects.create_user("keith", password="pw-keith-123")
client.login(username="keith", password="pw-keith-123")
response = client.get(reverse("accounts:logout"))
assert response.status_code == 405
@pytest.mark.django_db
def test_non_admin_cannot_manage_users(client):
User.objects.create_user("regular", password="pw-regular-123")
client.login(username="regular", password="pw-regular-123")
response = client.get(reverse("accounts:manage_users"))
assert response.status_code == 302 # user_passes_test redirects non-staff
@pytest.mark.django_db
def test_admin_can_create_user(client):
admin = User.objects.create_user("admin", password="pw-admin-123", is_staff=True)
client.login(username="admin", password="pw-admin-123")
response = client.post(
reverse("accounts:create_user"),
{
"username": "newperson",
"email": "newperson@example.com",
"password": "pw-newperson-123",
},
)
assert response.status_code == 302
assert User.objects.filter(username="newperson").exists()
assert admin.pk # sanity: fixture user untouched