Private
Public Access
Subscription editing was a real gap: there was no way to rename a feed's display title, move it between folders, or create a folder at all outside OPML import. Added an edit page (apps/feeds/views.py:edit_subscription, EditSubscriptionForm) reachable from the subscriptions list. Added feed-level tagging via a new SubscriptionTag model (apps/articles/ models.py), mirroring the existing ArticleTag — tag a whole feed on its edit page, and every one of its articles surfaces under that tag in the stream alongside individually-tagged articles (apps.reader.views._apply_ scope now matches either). Renamed AddTagToArticleForm to AddTagForm since it's shared by both now. The stream also now remembers the last filter (unread/all/starred/saved) in the session instead of always defaulting to "unread" when a sidebar feed/folder/tag link omits ?filter= — sidebar links no longer force ?filter=all, letting the remembered choice apply. Verified end to end against a running dev server: editing a subscription's title/folder, creating a folder inline, tagging a feed and seeing its articles appear under that tag, and the remembered-filter behavior across requests with no ?filter= param. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
157 lines
6.0 KiB
Python
157 lines
6.0 KiB
Python
import pytest
|
|
from django.contrib.auth import get_user_model
|
|
from django.urls import reverse
|
|
|
|
from apps.articles.models import Article, UserArticleState
|
|
from apps.feeds.models import Feed, Subscription
|
|
|
|
User = get_user_model()
|
|
|
|
|
|
@pytest.fixture
|
|
def alice(db):
|
|
return User.objects.create_user("alice", password="pw-alice-123")
|
|
|
|
|
|
@pytest.fixture
|
|
def bob(db):
|
|
return User.objects.create_user("bob", password="pw-bob-123")
|
|
|
|
|
|
@pytest.fixture
|
|
def alices_article(alice):
|
|
feed = Feed.objects.create(feed_url="https://example.com/feed.xml", title="Example")
|
|
Subscription.objects.create(user=alice, feed=feed)
|
|
return Article.objects.create(feed=feed, guid="guid-1", title="Hello world")
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_stream_requires_login(client):
|
|
response = client.get(reverse("reader:stream"))
|
|
assert response.status_code == 302
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_stream_shows_only_own_subscriptions(client, alice, bob, alices_article):
|
|
client.login(username="bob", password="pw-bob-123")
|
|
response = client.get(reverse("reader:stream"))
|
|
assert alices_article.title not in response.content.decode()
|
|
|
|
client.login(username="alice", password="pw-alice-123")
|
|
response = client.get(reverse("reader:stream"))
|
|
assert alices_article.title in response.content.decode()
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_unread_filter_excludes_read_articles(client, alice, alices_article):
|
|
UserArticleState.objects.create(user=alice, article=alices_article, is_read=True)
|
|
client.login(username="alice", password="pw-alice-123")
|
|
|
|
response = client.get(reverse("reader:stream"), {"filter": "unread"})
|
|
assert alices_article.title not in response.content.decode()
|
|
|
|
response = client.get(reverse("reader:stream"), {"filter": "all"})
|
|
assert alices_article.title in response.content.decode()
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_hidden_articles_are_excluded_from_every_filter(client, alice, alices_article):
|
|
UserArticleState.objects.create(user=alice, article=alices_article, is_hidden=True)
|
|
client.login(username="alice", password="pw-alice-123")
|
|
|
|
for active_filter in ["unread", "all"]:
|
|
response = client.get(reverse("reader:stream"), {"filter": active_filter})
|
|
assert alices_article.title not in response.content.decode()
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_viewing_article_detail_marks_it_read(client, alice, alices_article):
|
|
client.login(username="alice", password="pw-alice-123")
|
|
assert not UserArticleState.objects.filter(user=alice, article=alices_article).exists()
|
|
|
|
response = client.get(reverse("reader:article_detail", args=[alices_article.pk]))
|
|
assert response.status_code == 200
|
|
|
|
state = UserArticleState.objects.get(user=alice, article=alices_article)
|
|
assert state.is_read is True
|
|
assert state.read_at is not None
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_user_cannot_view_another_users_article(client, alice, bob, alices_article):
|
|
client.login(username="bob", password="pw-bob-123")
|
|
response = client.get(reverse("reader:article_detail", args=[alices_article.pk]))
|
|
assert response.status_code == 404
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_toggle_star_flips_state_and_persists(client, alice, alices_article):
|
|
client.login(username="alice", password="pw-alice-123")
|
|
url = reverse("reader:toggle_star", args=[alices_article.pk])
|
|
|
|
response = client.post(url)
|
|
assert response.status_code == 200
|
|
state = UserArticleState.objects.get(user=alice, article=alices_article)
|
|
assert state.is_starred is True
|
|
assert state.starred_at is not None
|
|
|
|
client.post(url)
|
|
state.refresh_from_db()
|
|
assert state.is_starred is False
|
|
assert state.starred_at is None
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_toggle_read_requires_post(client, alice, alices_article):
|
|
client.login(username="alice", password="pw-alice-123")
|
|
response = client.get(reverse("reader:toggle_read", args=[alices_article.pk]))
|
|
assert response.status_code == 405
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_user_cannot_toggle_state_on_another_users_article(client, alice, bob, alices_article):
|
|
client.login(username="bob", password="pw-bob-123")
|
|
response = client.post(reverse("reader:toggle_star", args=[alices_article.pk]))
|
|
assert response.status_code == 404
|
|
assert not UserArticleState.objects.filter(article=alices_article).exists()
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_stream_remembers_last_selected_filter(client, alice, alices_article):
|
|
UserArticleState.objects.create(user=alice, article=alices_article, is_starred=True)
|
|
client.login(username="alice", password="pw-alice-123")
|
|
|
|
response = client.get(reverse("reader:stream"), {"filter": "starred"})
|
|
assert response.context["active_filter"] == "starred"
|
|
|
|
# No ?filter= this time — e.g. a sidebar feed/tag link, or just "/" —
|
|
# should fall back to "starred" rather than resetting to "unread".
|
|
response = client.get(reverse("reader:stream"))
|
|
assert response.context["active_filter"] == "starred"
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_tag_filter_includes_articles_from_a_tagged_feed(client, alice, alices_article):
|
|
from apps.articles.models import SubscriptionTag, Tag
|
|
from apps.feeds.models import Subscription
|
|
|
|
client.login(username="alice", password="pw-alice-123")
|
|
tag = Tag.objects.create(user=alice, name="backend")
|
|
subscription = Subscription.objects.get(user=alice, feed=alices_article.feed)
|
|
SubscriptionTag.objects.create(user=alice, subscription=subscription, tag=tag)
|
|
|
|
response = client.get(reverse("reader:stream"), {"filter": "all", "tag": tag.pk})
|
|
assert alices_article.title in response.content.decode()
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_saved_filter_only_shows_saved_articles(client, alice, alices_article):
|
|
client.login(username="alice", password="pw-alice-123")
|
|
client.post(reverse("reader:toggle_saved", args=[alices_article.pk]))
|
|
|
|
response = client.get(reverse("reader:stream"), {"filter": "saved"})
|
|
assert alices_article.title in response.content.decode()
|
|
|
|
response = client.get(reverse("reader:stream"), {"filter": "starred"})
|
|
assert alices_article.title not in response.content.decode()
|