Private
Public Access
Make the Postgres search migration online-safe (R2-T3, #39)
One migration did a full-table UPDATE, a blocking GIN build and the trigger install together — long locks and a deploy that could outlast its health-check window on a large archive. Now two stages. 0002 only adds the nullable column and the trigger (metadata-only; new and updated rows get a vector from then on). 0003 is non-atomic: it backfills in 5,000-id batches, each its own short transaction and only touching rows still NULL, then builds the index with CREATE INDEX CONCURRENTLY (dropping a stale INVALID one from a failed earlier run first). Re-running is safe, and it's a cheap no-op on an install that applied the earlier single-step version. Measured on a real PostgreSQL 16 with 150,000 existing articles while a second connection kept inserting/updating: the migration took ~20s, the slowest concurrent write was 37ms (nothing blocked), no NULL vectors remained, the index was valid, and unapply/re-apply worked. Full suite passes on Postgres. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
72bffbe97f
commit
d6e310b127
2 files changed
+88
-7
No files matched your search
@@ -1,5 +1,12 @@
|
||||
"""Stored, GIN-indexed tsvector for Postgres search (C5), kept current by a
|
||||
trigger so no ingestion/update code path can forget to maintain it.
|
||||
"""Stored tsvector for Postgres search (C5), kept current by a trigger so
|
||||
no ingestion/update code path can forget to maintain it.
|
||||
|
||||
Stage 1 of 2, and deliberately cheap: it only adds the (nullable) column
|
||||
and installs the trigger, so new and updated rows get a vector from this
|
||||
point on. Both are metadata-only/brief-lock operations even on a huge
|
||||
table. The slow work — backfilling existing rows and building the GIN
|
||||
index — is 0003, done in batches and CONCURRENTLY so a large existing
|
||||
archive doesn't lock the table for the length of a deploy (R2-T3).
|
||||
|
||||
No-ops entirely on SQLite — its FTS5 table (0001_sqlite_fts) already plays
|
||||
this role. The column is deliberately not a Django model field: a
|
||||
@@ -17,11 +24,6 @@ VECTOR_EXPR = (
|
||||
CREATE = f"""
|
||||
ALTER TABLE articles_article ADD COLUMN IF NOT EXISTS search_vector tsvector;
|
||||
|
||||
UPDATE articles_article SET search_vector = {VECTOR_EXPR.format(row="")};
|
||||
|
||||
CREATE INDEX IF NOT EXISTS articles_article_search_vector_gin
|
||||
ON articles_article USING GIN (search_vector);
|
||||
|
||||
CREATE OR REPLACE FUNCTION articles_article_search_vector_update() RETURNS trigger AS $$
|
||||
BEGIN
|
||||
NEW.search_vector := {VECTOR_EXPR.format(row="NEW.")};
|
||||
|
||||
Reference in new issue
Block a user