Private
Public Access
S4: the throttle keyed on the first X-Forwarded-For entry, which a client or a proxy that appends can choose, and disabled itself entirely when Redis was down. EVECTION_TRUSTED_PROXIES (IPs/CIDRs of your reverse proxy) makes it strict: X-Forwarded-For is only believed when the TCP peer is a trusted proxy, and the rightmost entry that isn't itself a trusted proxy — the address the proxy actually saw — is used instead of the spoofable first one. Unset keeps the previous behavior so existing installs don't suddenly share one bucket behind a proxy, and `manage.py check --deploy` warns (evection.W001) until it's set. During a Redis outage the throttle now falls back to a bounded in-process limiter instead of switching off. C5: /health/ready/ reuses its queue/feed aggregates for 15s (EVECTION_HEALTH_CACHE_SECONDS) so a fast-polling monitor can't create steady load; the database, Redis and poller probes stay live. Docs cover both settings, restricting the endpoint at the proxy, and the tombstone/purge behavior from the previous changes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
aacb41d1d3
commit
ac5e951749
12 files changed
+386
-53
No files matched your search
@@ -265,3 +265,45 @@ def test_health_ready_flags_most_feeds_failing_but_not_a_single_broken_one(clien
|
||||
assert body["checks"]["feed_failures"] is False
|
||||
assert body["failing_feeds"] == 3
|
||||
assert healthy.pk and broken
|
||||
|
||||
|
||||
@pytest.mark.django_db
|
||||
def test_readiness_reuses_the_pipeline_aggregates_for_a_short_time(client, broker_queue, settings):
|
||||
"""R2-C5: the expensive part of the readiness check is cached briefly,
|
||||
while the cheap liveness probes stay live."""
|
||||
from django.core.cache import cache
|
||||
from django.utils import timezone
|
||||
|
||||
from apps.feeds.tasks import POLL_HEARTBEAT_CACHE_KEY
|
||||
|
||||
settings.EVECTION_HEALTH_CACHE_SECONDS = 30
|
||||
cache.set(POLL_HEARTBEAT_CACHE_KEY, timezone.now())
|
||||
Feed.objects.create(feed_url="https://a.example.com/feed.xml")
|
||||
|
||||
first = client.get(reverse("core:health_ready")).json()
|
||||
Feed.objects.create(feed_url="https://b.example.com/feed.xml")
|
||||
second = client.get(reverse("core:health_ready")).json()
|
||||
|
||||
assert first["active_feeds"] == 1
|
||||
assert second["active_feeds"] == 1, "served from the short-lived cache"
|
||||
|
||||
cache.delete("health-ready-pipeline")
|
||||
third = client.get(reverse("core:health_ready")).json()
|
||||
assert third["active_feeds"] == 2
|
||||
|
||||
|
||||
@pytest.mark.django_db
|
||||
def test_readiness_liveness_probes_are_never_cached(client, broker_queue, settings):
|
||||
from django.core.cache import cache
|
||||
|
||||
settings.EVECTION_HEALTH_CACHE_SECONDS = 30
|
||||
first = client.get(reverse("core:health_ready"))
|
||||
assert first.json()["checks"]["poll_heartbeat"] is False
|
||||
|
||||
from django.utils import timezone
|
||||
|
||||
from apps.feeds.tasks import POLL_HEARTBEAT_CACHE_KEY
|
||||
|
||||
cache.set(POLL_HEARTBEAT_CACHE_KEY, timezone.now())
|
||||
second = client.get(reverse("core:health_ready"))
|
||||
assert second.json()["checks"]["poll_heartbeat"] is True
|
||||
Reference in new issue
Block a user