Private
Public Access
Add login rate limiting (S6)
Django's default LoginView had no throttle — an internet-facing instance was exposed to unlimited password-guessing/credential- stuffing attempts. apps.accounts.views.LoginView adds two independent, Redis-cache-backed throttles (shared across all gunicorn workers, unlike the per-process default LocMemCache): by client address (catches one attacker spraying many usernames) and by the submitted username (catches a distributed attack on one specific account). Either blocks further attempts for a 5-minute window; both are generous enough not to lock out a user who's just mistyped their own password a few times. Client address prefers X-Forwarded-For's first hop, falling back to REMOTE_ADDR — the same reverse-proxy trust boundary config.settings.prod already relies on for X-Forwarded-Proto (gunicorn is never meant to be reachable except through that proxy). CACHES now points at Redis (already a hard install requirement for Celery) instead of Django's implicit per-process default, since the whole point is a shared counter across every gunicorn worker; test settings override it back to LocMemCache so the suite doesn't need a real Redis instance. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
9241a54958
commit
a1ea2e5662
5 files changed
+147
-6
No files matched your search
@@ -5,3 +5,10 @@ CELERY_TASK_ALWAYS_EAGER = True
|
||||
CELERY_TASK_EAGER_PROPAGATES = True
|
||||
|
||||
PASSWORD_HASHERS = ["django.contrib.auth.hashers.MD5PasswordHasher"]
|
||||
|
||||
# base.py's CACHES needs a real Redis instance — tests must not depend on
|
||||
# one being available, and a plain per-process cache is also what keeps
|
||||
# login-rate-limit tests isolated from each other (LocMemCache's default
|
||||
# location is per-process but shared across tests in that process; see
|
||||
# apps.accounts.test_rate_limit's cache.clear() fixture).
|
||||
CACHES = {"default": {"BACKEND": "django.core.cache.backends.locmem.LocMemCache"}}
|
||||
Reference in new issue
Block a user