Private
Public Access
Add login rate limiting (S6)
Django's default LoginView had no throttle — an internet-facing instance was exposed to unlimited password-guessing/credential- stuffing attempts. apps.accounts.views.LoginView adds two independent, Redis-cache-backed throttles (shared across all gunicorn workers, unlike the per-process default LocMemCache): by client address (catches one attacker spraying many usernames) and by the submitted username (catches a distributed attack on one specific account). Either blocks further attempts for a 5-minute window; both are generous enough not to lock out a user who's just mistyped their own password a few times. Client address prefers X-Forwarded-For's first hop, falling back to REMOTE_ADDR — the same reverse-proxy trust boundary config.settings.prod already relies on for X-Forwarded-Proto (gunicorn is never meant to be reachable except through that proxy). CACHES now points at Redis (already a hard install requirement for Celery) instead of Django's implicit per-process default, since the whole point is a shared counter across every gunicorn worker; test settings override it back to LocMemCache so the suite doesn't need a real Redis instance. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
9241a54958
commit
a1ea2e5662
5 files changed
+147
-6
No files matched your search
@@ -1,6 +1,8 @@
|
||||
from django.contrib import messages
|
||||
from django.contrib.auth import login
|
||||
from django.contrib.auth.decorators import user_passes_test
|
||||
from django.contrib.auth.views import LoginView as DjangoLoginView
|
||||
from django.core.cache import cache
|
||||
from django.db import IntegrityError, transaction
|
||||
from django.shortcuts import redirect, render
|
||||
|
||||
@@ -10,6 +12,68 @@ from .models import SetupLock, User
|
||||
|
||||
is_admin = user_passes_test(lambda u: u.is_authenticated and u.is_staff)
|
||||
|
||||
# Two independent throttles, either of which can block an attempt: by
|
||||
# client address (catches one attacker spraying many usernames) and by
|
||||
# the submitted username (catches a distributed/low-and-slow attack on
|
||||
# one specific account from many addresses). Both are generous enough
|
||||
# not to lock out a user who's just fat-fingered their own password a
|
||||
# few times.
|
||||
LOGIN_RATE_LIMIT_WINDOW_SECONDS = 5 * 60
|
||||
LOGIN_RATE_LIMIT_MAX_ATTEMPTS_PER_ADDRESS = 15
|
||||
LOGIN_RATE_LIMIT_MAX_ATTEMPTS_PER_USERNAME = 8
|
||||
|
||||
|
||||
def _client_address(request) -> str:
|
||||
# gunicorn is always run behind a reverse proxy in every deployment
|
||||
# (see docs/install.md) and its bind address is never meant to be
|
||||
# reachable from outside that proxy — the same trust boundary
|
||||
# config.settings.prod already relies on for X-Forwarded-Proto. A
|
||||
# direct request (e.g. local dev) has no X-Forwarded-For and falls
|
||||
# back to REMOTE_ADDR.
|
||||
forwarded_for = request.META.get("HTTP_X_FORWARDED_FOR", "")
|
||||
if forwarded_for:
|
||||
return forwarded_for.split(",")[0].strip()
|
||||
return request.META.get("REMOTE_ADDR", "unknown")
|
||||
|
||||
|
||||
def _attempts_key(kind: str, value: str) -> str:
|
||||
return f"login-attempts:{kind}:{value}"
|
||||
|
||||
|
||||
def _too_many_attempts(key: str, limit: int) -> bool:
|
||||
return cache.get(key, 0) >= limit
|
||||
|
||||
|
||||
def _record_failed_attempt(key: str) -> None:
|
||||
try:
|
||||
cache.incr(key)
|
||||
except ValueError:
|
||||
cache.set(key, 1, LOGIN_RATE_LIMIT_WINDOW_SECONDS)
|
||||
|
||||
|
||||
class LoginView(DjangoLoginView):
|
||||
"""Wraps Django's own LoginView with the throttle above — everything
|
||||
else (form, template, redirect behavior) is unchanged."""
|
||||
|
||||
template_name = "accounts/login.html"
|
||||
|
||||
def post(self, request, *args, **kwargs):
|
||||
address_key = _attempts_key("addr", _client_address(request))
|
||||
username_key = _attempts_key("user", request.POST.get("username", "")[:150])
|
||||
if _too_many_attempts(
|
||||
address_key, LOGIN_RATE_LIMIT_MAX_ATTEMPTS_PER_ADDRESS
|
||||
) or _too_many_attempts(username_key, LOGIN_RATE_LIMIT_MAX_ATTEMPTS_PER_USERNAME):
|
||||
messages.error(
|
||||
request, "Too many login attempts. Please wait a few minutes and try again."
|
||||
)
|
||||
return redirect("accounts:login")
|
||||
return super().post(request, *args, **kwargs)
|
||||
|
||||
def form_invalid(self, form):
|
||||
_record_failed_attempt(_attempts_key("addr", _client_address(self.request)))
|
||||
_record_failed_attempt(_attempts_key("user", self.request.POST.get("username", "")[:150]))
|
||||
return super().form_invalid(form)
|
||||
|
||||
|
||||
def setup(request):
|
||||
if User.objects.exists():
|
||||
|
||||
Reference in new issue
Block a user