Private
Public Access
Fix install.sh failing with permission denied creating the venv
EVECTION_HOME (the venv's parent directory, e.g. /opt/evection) was never chowned to the service user — only the app checkout inside it was — so venv creation failed with Permission denied whenever EVECTION_HOME was created by root before running the script (the documented quick-install steps do exactly that: mkdir + git clone as root, then run install.sh). Also run the release-tag git fetch/checkout as root instead of sudo -u $EVECTION_USER in both install.sh and upgrade.sh: the service user has no reason to have its own git credentials configured, so running as it just means the private repo's auth prompt hangs the script (as seen on this install) or silently fails. Root already has working credentials from the initial clone. Added GIT_TERMINAL_PROMPT=0 so a credential problem fails fast instead of hanging on a prompt either way. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
3e627b1ef8
commit
8c23cc631c
2 files changed
+26
-9
No files matched your search
+9
-4
@@ -46,14 +46,18 @@ fi
|
||||
|
||||
echo "==> Fetching latest release"
|
||||
cd "$APP_DIR"
|
||||
sudo -u "$EVECTION_USER" -H git fetch --tags --force
|
||||
LATEST_TAG="$(sudo -u "$EVECTION_USER" -H git tag --sort=-creatordate | head -n1)"
|
||||
# Run git as root (this script already requires it), not as $EVECTION_USER:
|
||||
# the service user has no reason to have its own git credentials set up,
|
||||
# and GIT_TERMINAL_PROMPT=0 means a credential problem fails fast instead
|
||||
# of hanging the upgrade on a silent username/password prompt.
|
||||
GIT_TERMINAL_PROMPT=0 git fetch --tags --force
|
||||
LATEST_TAG="$(git tag --sort=-creatordate | head -n1)"
|
||||
if [ -z "$LATEST_TAG" ]; then
|
||||
echo "No tags found in this repo — nothing to deploy." \
|
||||
"Cut and push a release tag first (e.g. git tag v$(date +%Y.%m.%d) && git push --tags)." >&2
|
||||
exit 1
|
||||
fi
|
||||
CURRENT_REF="$(sudo -u "$EVECTION_USER" -H git describe --tags --exact-match 2>/dev/null || echo "none")"
|
||||
CURRENT_REF="$(git describe --tags --exact-match 2>/dev/null || echo "none")"
|
||||
if [ "$CURRENT_REF" = "$LATEST_TAG" ]; then
|
||||
echo "Already on the latest tag ($LATEST_TAG) — nothing to do."
|
||||
exit 0
|
||||
@@ -61,7 +65,8 @@ fi
|
||||
echo "Deploying $LATEST_TAG (currently on: $CURRENT_REF)"
|
||||
# Detached HEAD, not a branch checkout — this directory only ever runs a
|
||||
# tagged release, never whatever the default branch's tip happens to be.
|
||||
sudo -u "$EVECTION_USER" -H git checkout --quiet --detach "$LATEST_TAG"
|
||||
git checkout --quiet --detach "$LATEST_TAG"
|
||||
chown -R "$EVECTION_USER:$EVECTION_USER" "$APP_DIR"
|
||||
|
||||
echo "==> Installing updated dependencies"
|
||||
sudo -u "$EVECTION_USER" -H "$VENV_DIR/bin/pip" install --upgrade "$APP_DIR"
|
||||
|
||||
Reference in new issue
Block a user