From 78611c0eae25e62498614699a64da5fb9a642838 Mon Sep 17 00:00:00 2001 From: Keith Smith Date: Sat, 31 Oct 2026 08:51:28 -0600 Subject: [PATCH] Check for a working venv module before install.sh does anything else MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Debian/Ubuntu, python3-venv (ensurepip support) is a separate package from python3 itself, and apt installing just python3 leaves venv creation failing partway through install.sh — after the system user, chown, and git checkout have all already happened. Check for it up front alongside the Python version check, and document the apt package in install.md's prerequisites. Co-Authored-By: Claude Sonnet 5 --- docs/install.md | 8 +++++--- scripts/install.sh | 5 +++++ 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/docs/install.md b/docs/install.md index ee14663..1e37e1a 100644 --- a/docs/install.md +++ b/docs/install.md @@ -55,7 +55,8 @@ and 4 below first — prerequisites and what `.env` controls. ## 1. Prerequisites -- Python 3.11 or 3.12 +- Python 3.11 or 3.12, with its `venv` module (Debian/Ubuntu split this into a + separate `python3.X-venv` package — see below) - Redis (Celery's broker) - **Postgres only**: a PostgreSQL server (12+) and its client headers if you're not using the bundled `psycopg[binary]` wheel (most platforms are covered by the wheel, @@ -63,10 +64,11 @@ and 4 below first — prerequisites and what `.env` controls. - nginx (or another reverse proxy) - A domain name pointed at the host, if you want this reachable outside your LAN -Debian/Ubuntu example for the non-Python pieces: +Debian/Ubuntu example for the non-Python pieces (swap `python3.13-venv` for +whatever `python3 --version` reports on your system): ```bash -sudo apt install redis-server nginx +sudo apt install redis-server nginx python3.13-venv # Postgres only: sudo apt install postgresql ``` diff --git a/scripts/install.sh b/scripts/install.sh index 17c6d0e..6496169 100755 --- a/scripts/install.sh +++ b/scripts/install.sh @@ -52,6 +52,11 @@ if [ "$PY_MAJOR" -lt 3 ] || { [ "$PY_MAJOR" -eq 3 ] && [ "$PY_MINOR" -lt 11 ]; } echo "Python $PY_VERSION found, but Evection needs 3.11 or newer." >&2 exit 1 fi +if ! "$PYTHON_BIN" -c 'import ensurepip' >/dev/null 2>&1; then + echo "'$PYTHON_BIN' can't create virtualenvs (no ensurepip) — on" \ + "Debian/Ubuntu, install it with: apt install python${PY_VERSION}-venv" >&2 + exit 1 +fi for bin in redis-cli nginx; do if ! command -v "$bin" >/dev/null 2>&1; then