Private
Public Access
Add the reading UI: stream, article detail, htmx actions
Implements the main reader surface: a filterable stream (Unread/All/ Starred/Saved) built on the lazy UserArticleState query pattern, an article detail view that marks articles read on open, and htmx-backed read/star/save-for-later toggles that update in place without a full page reload. Rule-hidden articles are excluded from every filter. Vendors htmx locally rather than loading it from a CDN, and adds mobile-first responsive CSS (verified at 375px width in-browser, plus dark mode via prefers-color-scheme). Verified live against the real Hacker News feed subscribed in the previous milestone: ingestion, filter switching, read/star/save toggles, and article detail all confirmed working in the browser, with two UI bugs fixed along the way (low-contrast message banners in dark mode, horizontal overflow from long URLs in article content). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
d200ab80f7
commit
69e3520e3b
11 files changed
+478
-9
No files matched your search
+128
-1
@@ -1 +1,128 @@
|
||||
# Create your tests here.
|
||||
import pytest
|
||||
from django.contrib.auth import get_user_model
|
||||
from django.urls import reverse
|
||||
|
||||
from apps.articles.models import Article, UserArticleState
|
||||
from apps.feeds.models import Feed, Subscription
|
||||
|
||||
User = get_user_model()
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def alice(db):
|
||||
return User.objects.create_user("alice", password="pw-alice-123")
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def bob(db):
|
||||
return User.objects.create_user("bob", password="pw-bob-123")
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def alices_article(alice):
|
||||
feed = Feed.objects.create(feed_url="https://example.com/feed.xml", title="Example")
|
||||
Subscription.objects.create(user=alice, feed=feed)
|
||||
return Article.objects.create(feed=feed, guid="guid-1", title="Hello world")
|
||||
|
||||
|
||||
@pytest.mark.django_db
|
||||
def test_stream_requires_login(client):
|
||||
response = client.get(reverse("reader:stream"))
|
||||
assert response.status_code == 302
|
||||
|
||||
|
||||
@pytest.mark.django_db
|
||||
def test_stream_shows_only_own_subscriptions(client, alice, bob, alices_article):
|
||||
client.login(username="bob", password="pw-bob-123")
|
||||
response = client.get(reverse("reader:stream"))
|
||||
assert alices_article.title not in response.content.decode()
|
||||
|
||||
client.login(username="alice", password="pw-alice-123")
|
||||
response = client.get(reverse("reader:stream"))
|
||||
assert alices_article.title in response.content.decode()
|
||||
|
||||
|
||||
@pytest.mark.django_db
|
||||
def test_unread_filter_excludes_read_articles(client, alice, alices_article):
|
||||
UserArticleState.objects.create(user=alice, article=alices_article, is_read=True)
|
||||
client.login(username="alice", password="pw-alice-123")
|
||||
|
||||
response = client.get(reverse("reader:stream"), {"filter": "unread"})
|
||||
assert alices_article.title not in response.content.decode()
|
||||
|
||||
response = client.get(reverse("reader:stream"), {"filter": "all"})
|
||||
assert alices_article.title in response.content.decode()
|
||||
|
||||
|
||||
@pytest.mark.django_db
|
||||
def test_hidden_articles_are_excluded_from_every_filter(client, alice, alices_article):
|
||||
UserArticleState.objects.create(user=alice, article=alices_article, is_hidden=True)
|
||||
client.login(username="alice", password="pw-alice-123")
|
||||
|
||||
for active_filter in ["unread", "all"]:
|
||||
response = client.get(reverse("reader:stream"), {"filter": active_filter})
|
||||
assert alices_article.title not in response.content.decode()
|
||||
|
||||
|
||||
@pytest.mark.django_db
|
||||
def test_viewing_article_detail_marks_it_read(client, alice, alices_article):
|
||||
client.login(username="alice", password="pw-alice-123")
|
||||
assert not UserArticleState.objects.filter(user=alice, article=alices_article).exists()
|
||||
|
||||
response = client.get(reverse("reader:article_detail", args=[alices_article.pk]))
|
||||
assert response.status_code == 200
|
||||
|
||||
state = UserArticleState.objects.get(user=alice, article=alices_article)
|
||||
assert state.is_read is True
|
||||
assert state.read_at is not None
|
||||
|
||||
|
||||
@pytest.mark.django_db
|
||||
def test_user_cannot_view_another_users_article(client, alice, bob, alices_article):
|
||||
client.login(username="bob", password="pw-bob-123")
|
||||
response = client.get(reverse("reader:article_detail", args=[alices_article.pk]))
|
||||
assert response.status_code == 404
|
||||
|
||||
|
||||
@pytest.mark.django_db
|
||||
def test_toggle_star_flips_state_and_persists(client, alice, alices_article):
|
||||
client.login(username="alice", password="pw-alice-123")
|
||||
url = reverse("reader:toggle_star", args=[alices_article.pk])
|
||||
|
||||
response = client.post(url)
|
||||
assert response.status_code == 200
|
||||
state = UserArticleState.objects.get(user=alice, article=alices_article)
|
||||
assert state.is_starred is True
|
||||
assert state.starred_at is not None
|
||||
|
||||
client.post(url)
|
||||
state.refresh_from_db()
|
||||
assert state.is_starred is False
|
||||
assert state.starred_at is None
|
||||
|
||||
|
||||
@pytest.mark.django_db
|
||||
def test_toggle_read_requires_post(client, alice, alices_article):
|
||||
client.login(username="alice", password="pw-alice-123")
|
||||
response = client.get(reverse("reader:toggle_read", args=[alices_article.pk]))
|
||||
assert response.status_code == 405
|
||||
|
||||
|
||||
@pytest.mark.django_db
|
||||
def test_user_cannot_toggle_state_on_another_users_article(client, alice, bob, alices_article):
|
||||
client.login(username="bob", password="pw-bob-123")
|
||||
response = client.post(reverse("reader:toggle_star", args=[alices_article.pk]))
|
||||
assert response.status_code == 404
|
||||
assert not UserArticleState.objects.filter(article=alices_article).exists()
|
||||
|
||||
|
||||
@pytest.mark.django_db
|
||||
def test_saved_filter_only_shows_saved_articles(client, alice, alices_article):
|
||||
client.login(username="alice", password="pw-alice-123")
|
||||
client.post(reverse("reader:toggle_saved", args=[alices_article.pk]))
|
||||
|
||||
response = client.get(reverse("reader:stream"), {"filter": "saved"})
|
||||
assert alices_article.title in response.content.decode()
|
||||
|
||||
response = client.get(reverse("reader:stream"), {"filter": "starred"})
|
||||
assert alices_article.title not in response.content.decode()
|
||||
Reference in new issue
Block a user