Private
Public Access
Allow only http(s) URLs from feeds and OPML, at storage and render (R2-S1, #33)
A feed's channel link, an entry's link and an OPML htmlUrl were stored as given and rendered in href attributes (bulk writes skip model validation), so a malicious feed could supply a javascript: or data: link. CSP is a second layer, not the control. apps.core.urlutils accepts only absolute http(s) URLs. Fetching stores channel/entry links through it — relative links now resolve against the feed's own URL instead of being stored as dead relative paths — OPML import skips non-http(s) feed URLs and blanks unsafe htmlUrl, and the add-feed form rejects non-http(s) (URLField also allows ftp). A safe_http_url template filter guards the two places a feed-supplied URL becomes a link (the article's "Original" link and the dashboard), so values already in the database from before this fix are neutralized too. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
85914f9107
commit
41f99e9405
13 files changed
+192
-7
No files matched your search
+5
-2
@@ -17,6 +17,7 @@ from io import BytesIO
|
||||
import defusedxml.ElementTree as DefusedET
|
||||
|
||||
from apps.articles.models import SubscriptionTag, Tag
|
||||
from apps.core.urlutils import http_url_or_empty
|
||||
|
||||
from .models import Feed, Subscription
|
||||
|
||||
@@ -66,7 +67,9 @@ def parse_opml(file_obj) -> list[dict]:
|
||||
|
||||
def walk(container, ancestor_names):
|
||||
for outline in container.findall("outline"):
|
||||
xml_url = outline.get("xmlUrl")
|
||||
xml_url = http_url_or_empty(outline.get("xmlUrl"))
|
||||
if outline.get("xmlUrl") and not xml_url:
|
||||
continue # a feed URL that isn't http(s) can never be fetched
|
||||
if xml_url:
|
||||
tag_names = list(ancestor_names)
|
||||
category_attr = outline.get("category")
|
||||
@@ -79,7 +82,7 @@ def parse_opml(file_obj) -> list[dict]:
|
||||
{
|
||||
"feed_url": xml_url,
|
||||
"title": outline.get("title") or outline.get("text") or "",
|
||||
"site_url": outline.get("htmlUrl") or "",
|
||||
"site_url": http_url_or_empty(outline.get("htmlUrl")),
|
||||
"tag_names": tag_names,
|
||||
}
|
||||
)
|
||||
|
||||
Reference in new issue
Block a user