diff --git a/apps/accounts/tests.py b/apps/accounts/tests.py index ec1b990..31dde17 100644 --- a/apps/accounts/tests.py +++ b/apps/accounts/tests.py @@ -72,6 +72,30 @@ def test_setup_rejects_mismatched_passwords(client): assert not User.objects.exists() +@pytest.mark.django_db +def test_logout_via_post_logs_the_user_out(client): + User.objects.create_user("keith", password="pw-keith-123") + client.login(username="keith", password="pw-keith-123") + + response = client.post(reverse("accounts:logout")) + assert response.status_code == 302 + + stream_response = client.get(reverse("reader:stream")) + assert stream_response.status_code == 302 + assert stream_response.url.startswith(reverse("accounts:login")) + + +@pytest.mark.django_db +def test_logout_rejects_get(client): + # Django's LogoutView only accepts POST (see templates/core/_sidebar.html, + # which submits it as a form rather than a plain link). + User.objects.create_user("keith", password="pw-keith-123") + client.login(username="keith", password="pw-keith-123") + + response = client.get(reverse("accounts:logout")) + assert response.status_code == 405 + + @pytest.mark.django_db def test_non_admin_cannot_manage_users(client): User.objects.create_user("regular", password="pw-regular-123") diff --git a/static/css/base.css b/static/css/base.css index 4e1e28a..cb6921b 100644 --- a/static/css/base.css +++ b/static/css/base.css @@ -238,16 +238,22 @@ form p { padding: 0 0.5rem; } -.sidebar-top-nav li a { +.sidebar-top-nav li a, +.sidebar-top-nav li button { display: block; + width: 100%; padding: 0.4rem 0.75rem; color: var(--text-muted); text-decoration: none; + border: none; border-radius: 0.375rem; font-size: 0.9rem; + text-align: left; + background: none; } -.sidebar-top-nav li a:hover { +.sidebar-top-nav li a:hover, +.sidebar-top-nav li button:hover { background: var(--bg-row-hover); color: var(--text); } diff --git a/templates/core/_sidebar.html b/templates/core/_sidebar.html index 2659a70..ac67f85 100644 --- a/templates/core/_sidebar.html +++ b/templates/core/_sidebar.html @@ -75,7 +75,12 @@